[master] Support enums in OpenAPI to Ballerina client and types generation #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneeshafedo
force-pushed
the
enum-1.5.x
branch
2 times, most recently
from
7d74b59
to
74a9b3e
Compare
…-tools into null-constraint-1.5.x
aneeshafedo
force-pushed
the
enum-1.5.x
branch
2 times, most recently
from
16ead48
to
8223164
Compare
aneeshafedo
changed the title
aneeshafedo
requested review from
hevayo,
NipunaRanasinghe and
lnash94
as code owners
aneeshafedo
changed the title
aneeshafedo
changed the title
Closed
3 tasks
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master ballerina-platform/openapi-tools#1328 +/- ##
============================================
- Coverage 78.95% 78.91% -0.04%
- Complexity 1636 1656 +20
============================================
Files 123 124 +1
Lines 9641 9690 +49
Branches 1554 1569 +15
============================================
+ Hits 7612 7647 +35
- Misses 1463 1470 +7
- Partials 566 573 +7
☔ View full report in Codecov by Sentry. |
lnash94
reviewed
May 2, 2023
...api-cli/src/test/java/io/ballerina/openapi/generators/client/ComparedGeneratedFileTests.java
Outdated
Show resolved
Hide resolved
openapi-cli/src/test/java/io/ballerina/openapi/generators/client/EnumGenerationTests.java
Outdated
Show resolved
Hide resolved
openapi-cli/src/test/java/io/ballerina/openapi/generators/client/EnumGenerationTests.java
Show resolved
Hide resolved
openapi-cli/src/test/java/io/ballerina/openapi/generators/schema/ConstraintTests.java
Outdated
Show resolved
Hide resolved
openapi-cli/src/test/java/io/ballerina/openapi/generators/schema/EnumGenerationTests.java
Outdated
Show resolved
Hide resolved
openapi-cli/src/test/java/io/ballerina/openapi/generators/client/EnumGenerationTests.java
Outdated
Show resolved
Hide resolved
NipunaRanasinghe
approved these changes
May 3, 2023
lnash94
approved these changes
May 3, 2023
…i-tools into enum-1.5.x # Conflicts: # openapi-core/src/main/java/io/ballerina/openapi/core/generators/service/ParametersGenerator.java
openapi-cli/src/test/java/io/ballerina/openapi/generators/schema/EnumGenerationTests.java
Outdated
Show resolved
Hide resolved
.../java/io/ballerina/openapi/core/generators/schema/ballerinatypegenerators/EnumGenerator.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Check List
Enum Generation in parameters in Client generation
Enum generation in schema
Security checks
Test environment