Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serviceId selection logic to update the generated OAS context #1643

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

ayeshLK
Copy link
Member

@ayeshLK ayeshLK commented Apr 3, 2024

Purpose

$subject

Part of: #3195

@ayeshLK ayeshLK requested review from TharmiganK and removed request for hevayo April 3, 2024 09:53
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.18%. Comparing base (cb6e4d2) to head (cc560b5).
Report is 1 commits behind head on master.

Files Patch % Lines
...extension/doc/gen/AbstractOpenApiDocGenerator.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1643      +/-   ##
============================================
+ Coverage     79.16%   79.18%   +0.02%     
  Complexity     2199     2199              
============================================
  Files           178      178              
  Lines         11099    11098       -1     
  Branches       1795     1795              
============================================
+ Hits           8786     8788       +2     
+ Misses         1678     1676       -2     
+ Partials        635      634       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Apr 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@NipunaRanasinghe NipunaRanasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayeshLK ayeshLK merged commit 2fd027a into ballerina-platform:master Apr 3, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants