-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Splines #51
Comments
Hi @aflaxman! Thanks for opening this issue. Indeed, adding splines to On the other hand, it's true that In the meantime, Bambi will continue using I'll post or link splines updates here so you can follow along 😄 |
Great, thanks so much!
|
See #52. Turns out it wasn't that hard to add b-splines here. Unfortunately there are some things that have to be sorted out in Bambi before this function works there. |
#52 has been merged. Do not try to use with Bambi yet, since it does not know how to work with splines yet. |
@tomicapretto This is great news, which I stumbled across by change, almost worth an announcement somewhere 😄 |
Hi, @lorentzenchr sorry for the late reply. There's now a note on Patsy README mentioning this change, see here. Maybe an announcement will come after we implement some features such as random effects in Formulaic (which is a WIP). Of course, if you have any ideas or suggestions, I'd love to know them. |
Hi all. I would like to start with my appreciation for your work on
Bambi
andformulae
! I think both of these are very valuable additions to the scientific python stack. I saw a thread on twitter that made me thinkformulae
might become the newpatsy
, so I thought I would describe an affordance inpatsy
that would be really cool to add toformulae
: splines: https://patsy.readthedocs.io/en/latest/spline-regression.htmlI would love to be able to include
bs(x)
in one line, e.g.Since this is already implemented in
patsy
maybe it will not be too hard to add here, as well! Thanks again for all of your work!The text was updated successfully, but these errors were encountered: