-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simulator overlapping #1137
Conversation
Deploying carbon-app with
|
Latest commit: |
a2e01be
|
Status: | ✅ Deploy successful! |
Preview URL: | https://cb3a6bb6.carbon-app-csq.pages.dev |
Branch Preview URL: | https://simulator-overlapping.carbon-app-csq.pages.dev |
…lator/overlapping
|
# Conflicts: # e2e/screenshots/simulator/recurring/Recurring limit limit/form.jpg # e2e/screenshots/simulator/recurring/Recurring limit limit/simulator-input-price.jpg # e2e/screenshots/simulator/recurring/Recurring limit limit/simulator-results-animation.jpg # e2e/screenshots/simulator/recurring/Recurring limit limit/simulator-results-summary.jpg # e2e/screenshots/simulator/recurring/Recurring limit range/form.jpg # e2e/screenshots/simulator/recurring/Recurring limit range/simulator-input-price.jpg # e2e/screenshots/simulator/recurring/Recurring limit range/simulator-results-animation.jpg # e2e/screenshots/simulator/recurring/Recurring limit range/simulator-results-summary.jpg # e2e/screenshots/simulator/recurring/Recurring range limit/form.jpg # e2e/screenshots/simulator/recurring/Recurring range limit/simulator-input-price.jpg # e2e/screenshots/simulator/recurring/Recurring range limit/simulator-results-animation.jpg # e2e/screenshots/simulator/recurring/Recurring range limit/simulator-results-summary.jpg # e2e/screenshots/simulator/recurring/Recurring range range/form.jpg # e2e/screenshots/simulator/recurring/Recurring range range/simulator-input-price.jpg # e2e/screenshots/simulator/recurring/Recurring range range/simulator-results-animation.jpg # e2e/screenshots/simulator/recurring/Recurring range range/simulator-results-summary.jpg # e2e/screenshots/strategy/disposable/Disposable buy limit/create/form.jpg # e2e/screenshots/strategy/disposable/Disposable buy limit/create/my-strategy.jpg # e2e/screenshots/strategy/disposable/Disposable buy limit/deposit/form.jpg # e2e/screenshots/strategy/disposable/Disposable buy limit/editPrices/form.jpg # e2e/screenshots/strategy/disposable/Disposable buy limit/withdraw/form.jpg # e2e/screenshots/strategy/disposable/Disposable buy range/create/form.jpg # e2e/screenshots/strategy/disposable/Disposable buy range/create/my-strategy.jpg # e2e/screenshots/strategy/disposable/Disposable buy range/deposit/form.jpg # e2e/screenshots/strategy/disposable/Disposable buy range/editPrices/form.jpg # e2e/screenshots/strategy/disposable/Disposable buy range/withdraw/form.jpg # e2e/screenshots/strategy/disposable/Disposable sell limit/create/form.jpg # e2e/screenshots/strategy/disposable/Disposable sell limit/create/my-strategy.jpg # e2e/screenshots/strategy/disposable/Disposable sell limit/deposit/form.jpg # e2e/screenshots/strategy/disposable/Disposable sell limit/editPrices/form.jpg # e2e/screenshots/strategy/disposable/Disposable sell limit/withdraw/form.jpg # e2e/screenshots/strategy/disposable/Disposable sell range/create/form.jpg # e2e/screenshots/strategy/disposable/Disposable sell range/create/my-strategy.jpg # e2e/screenshots/strategy/disposable/Disposable sell range/deposit/form.jpg # e2e/screenshots/strategy/disposable/Disposable sell range/editPrices/form.jpg # e2e/screenshots/strategy/disposable/Disposable sell range/withdraw/form.jpg # e2e/screenshots/strategy/overlapping/Overlapping/create/form.jpg # e2e/screenshots/strategy/overlapping/Overlapping/create/my-strategy.jpg # e2e/screenshots/strategy/recurring/Recurring limit limit/create/form.jpg # e2e/screenshots/strategy/recurring/Recurring limit limit/create/my-strategy.jpg # e2e/screenshots/strategy/recurring/Recurring limit limit/deposit/form.jpg # e2e/screenshots/strategy/recurring/Recurring limit limit/editPrices/form.jpg # e2e/screenshots/strategy/recurring/Recurring limit limit/renew/form.jpg # e2e/screenshots/strategy/recurring/Recurring limit limit/withdraw/form.jpg # e2e/screenshots/strategy/recurring/Recurring limit range/create/form.jpg # e2e/screenshots/strategy/recurring/Recurring limit range/create/my-strategy.jpg # e2e/screenshots/strategy/recurring/Recurring limit range/deposit/form.jpg # e2e/screenshots/strategy/recurring/Recurring limit range/editPrices/form.jpg # e2e/screenshots/strategy/recurring/Recurring limit range/renew/form.jpg # e2e/screenshots/strategy/recurring/Recurring limit range/withdraw/form.jpg # e2e/screenshots/strategy/recurring/Recurring range limit/create/form.jpg # e2e/screenshots/strategy/recurring/Recurring range limit/create/my-strategy.jpg # e2e/screenshots/strategy/recurring/Recurring range limit/deposit/form.jpg # e2e/screenshots/strategy/recurring/Recurring range limit/editPrices/form.jpg # e2e/screenshots/strategy/recurring/Recurring range limit/renew/form.jpg # e2e/screenshots/strategy/recurring/Recurring range limit/withdraw/form.jpg # e2e/screenshots/strategy/recurring/Recurring range range/create/form.jpg # e2e/screenshots/strategy/recurring/Recurring range range/create/my-strategy.jpg # e2e/screenshots/strategy/recurring/Recurring range range/deposit/form.jpg # e2e/screenshots/strategy/recurring/Recurring range range/editPrices/form.jpg # e2e/screenshots/strategy/recurring/Recurring range range/renew/form.jpg # e2e/screenshots/strategy/recurring/Recurring range range/withdraw/form.jpg
Updated text
Current main title: "Withdraw Budget" Deposit: Create strategy/simulation |
…r/overlapping # Conflicts: # e2e/screenshots/simulator/recurring/Recurring limit limit/form.jpg # e2e/screenshots/simulator/recurring/Recurring limit limit/simulator-results-summary.jpg # e2e/screenshots/simulator/recurring/Recurring limit range/form.jpg # e2e/screenshots/simulator/recurring/Recurring range limit/form.jpg # e2e/screenshots/simulator/recurring/Recurring range range/form.jpg # e2e/screenshots/simulator/recurring/Recurring range range/simulator-input-price.jpg # e2e/screenshots/simulator/recurring/Recurring range range/simulator-results-animation.jpg # e2e/screenshots/strategy/disposable/Disposable buy limit/create/form.jpg # e2e/screenshots/strategy/disposable/Disposable buy limit/deposit/form.jpg # e2e/screenshots/strategy/disposable/Disposable buy limit/editPrices/form.jpg # e2e/screenshots/strategy/disposable/Disposable buy limit/withdraw/form.jpg # e2e/screenshots/strategy/disposable/Disposable buy range/create/form.jpg # e2e/screenshots/strategy/disposable/Disposable buy range/deposit/form.jpg # e2e/screenshots/strategy/disposable/Disposable buy range/editPrices/form.jpg # e2e/screenshots/strategy/disposable/Disposable buy range/withdraw/form.jpg # e2e/screenshots/strategy/disposable/Disposable sell limit/create/form.jpg # e2e/screenshots/strategy/disposable/Disposable sell limit/editPrices/form.jpg # e2e/screenshots/strategy/disposable/Disposable sell limit/withdraw/form.jpg # e2e/screenshots/strategy/disposable/Disposable sell range/create/form.jpg # e2e/screenshots/strategy/disposable/Disposable sell range/deposit/form.jpg # e2e/screenshots/strategy/disposable/Disposable sell range/editPrices/form.jpg # e2e/screenshots/strategy/disposable/Disposable sell range/withdraw/form.jpg # e2e/screenshots/strategy/overlapping/Overlapping/create/form.jpg # e2e/screenshots/strategy/recurring/Recurring limit limit/create/form.jpg # e2e/screenshots/strategy/recurring/Recurring limit limit/editPrices/form.jpg # e2e/screenshots/strategy/recurring/Recurring limit limit/renew/form.jpg # e2e/screenshots/strategy/recurring/Recurring limit range/create/form.jpg # e2e/screenshots/strategy/recurring/Recurring limit range/deposit/form.jpg # e2e/screenshots/strategy/recurring/Recurring limit range/editPrices/form.jpg # e2e/screenshots/strategy/recurring/Recurring limit range/renew/form.jpg # e2e/screenshots/strategy/recurring/Recurring limit range/withdraw/form.jpg # e2e/screenshots/strategy/recurring/Recurring range limit/create/form.jpg # e2e/screenshots/strategy/recurring/Recurring range limit/editPrices/form.jpg # e2e/screenshots/strategy/recurring/Recurring range limit/renew/form.jpg # e2e/screenshots/strategy/recurring/Recurring range limit/withdraw/form.jpg # e2e/screenshots/strategy/recurring/Recurring range range/create/form.jpg # e2e/screenshots/strategy/recurring/Recurring range range/deposit/form.jpg # e2e/screenshots/strategy/recurring/Recurring range range/editPrices/form.jpg # e2e/screenshots/strategy/recurring/Recurring range range/withdraw/form.jpg
src/components/simulator/input/d3Chart/overlapping/D3ChartOverlapping.tsx
Outdated
Show resolved
Hide resolved
src/components/simulator/input/d3Chart/recurring/D3ChartRecurring.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!!!
Observed while reviewing (feel free to ignore):
- Because the result page is not keeping track of overlapping buy and sell budgets:
- When simulating an overlapping strategy and going back, the buy and sell budgets are cleared in the simulator input page
- Creating a strategy from the overlapping simulator doesn't populate budgets
- Swapping tokens in simulator overlapping input clears the buy/sell budget
- Cannot change simulation dates in overlapping results page, but can change them in the input. While I understand this is a deliberate choice, it is possible to set dates in the simulation input which makes the behaviour a bit inconsistent. An issue to enable the calendar for simulator result page in a separate PR could be created
Bug:
- After swapping to overlapping from recurring, then changing token, the prices shows N/A
- Go to simulator input recurring, pick something like ETH/USDT
- Change to overlapping, the token choice stayed
- Change the quote token and the price chart shows N/A
src/components/simulator/input/overlapping/CreateOverlappingStrategyBudget.tsx
Show resolved
Hide resolved
src/components/simulator/input/overlapping/CreateOverlappingStrategyBudget.tsx
Show resolved
Hide resolved
src/components/simulator/input/overlapping/CreateOverlappingStrategy.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Tiago <66181828+tiagofilipenunes@users.noreply.github.com>
Co-authored-by: Tiago <66181828+tiagofilipenunes@users.noreply.github.com>
…lator/overlapping
Co-authored-by: Tiago <66181828+tiagofilipenunes@users.noreply.github.com>
…r/overlapping # Conflicts: # e2e/screenshots/simulator/recurring/Recurring limit range/simulator-input-price.jpg # e2e/screenshots/simulator/recurring/Recurring range limit/simulator-input-price.jpg # e2e/screenshots/strategy/disposable/Disposable sell limit/deposit/form.jpg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work !
This PR fixes:
#957 PR: #1164
#1124 PR: #1160
and overlapping simulator feature