Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strategy deletion popup #957

Closed
Costa769 opened this issue Dec 28, 2023 · 0 comments · Fixed by #1164
Closed

Strategy deletion popup #957

Costa769 opened this issue Dec 28, 2023 · 0 comments · Fixed by #1164
Assignees
Milestone

Comments

@Costa769
Copy link
Collaborator

Costa769 commented Dec 28, 2023

Designs

Popup to suggest strategy deletion

Overview

When a user withdraws the entire budget allocated to a strategy, we want to provide them with the option to delete that strategy. This way, we can avoid maintaining a list of inactive strategies and keep the platform more organized.

Reminder
The Withdrawal page is accessed by clicking on the "Withdraw funds" option in the overview card manage menu.

Flow

  1. User opens a withdraw funds page
  2. User enters the amount to withdraw
  3. User clicks on the “Withdraw” button
  4. On “Withdraw” CTA click check the following:
  • IF both budgets are fully withdrawn( both budgets=0)
    -- Show the popup to suggest strategy deletion
  • ELSE, IF at least one of the budgets >0
    -- No change to the current flow(proceed with the withdrawal)

Popup actions:

  • On "X" icon click
    -- Close the popup
  • On click outside the popup
    -- Close the popup.
  • On “Withdraw only” click
    -- Proceed with funds withdrawal flow (once the transaction is confirmed in the wallet, redirect the user to My strategies overview page)
  • On "Withdraw and Delete" click:
    -- Trigger the "deleteStrategy" function (once the transaction is confirmed in the wallet, redirect the user to My strategies overview page)

Empty strategy warning

Remove the following warning from the overlapping strategy withdraw funds page. This warning is displayed when user tries to withdraw the entire strategie's budget
"Please note that your strategy will be inactive as it will not have any budget."

@Costa769 Costa769 added this to the RC1 milestone Dec 28, 2023
@Costa769 Costa769 self-assigned this Dec 28, 2023
@ashachaf ashachaf removed their assignment Jan 18, 2024
@Costa769 Costa769 removed their assignment Feb 29, 2024
@pingustar pingustar self-assigned this Apr 9, 2024
@pingustar pingustar linked a pull request Apr 10, 2024 that will close this issue
pingustar added a commit that referenced this issue Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants