Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show unknown market price warning #1209

Merged
merged 13 commits into from
May 15, 2024
Merged

Show unknown market price warning #1209

merged 13 commits into from
May 15, 2024

Commits on May 8, 2024

  1. Add warning for market price unknown 

    - Check market price is unknown in useWarning
- Add warning text to LimitRangeSection to use in non-overlapping strategies
    @tiagofilipenunes
    tiagofilipenunes committed May 8, 2024
    Configuration menu
    Copy the full SHA
    cb57dda View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Change Overlapping Strategy Graph based on price availability 

    - If price is not available, center the graph in the middle of the max and min prices
- If the price is not available, hide the market price in the graph
- If the price is not available, hide the price-source text
    @tiagofilipenunes
    tiagofilipenunes committed May 9, 2024
    Configuration menu
    Copy the full SHA
    25c1bd9 View commit details
    Browse the repository at this point in the history

  2. Change price & slippage are unknown text color in trade page

    @tiagofilipenunes
    tiagofilipenunes committed May 9, 2024
    Configuration menu
    Copy the full SHA
    004c80f View commit details
    Browse the repository at this point in the history

  3. Fix passing around marketPrice as 0 instead of undefined 

    - Remove getMarketPrice and use useMarketPrice in DebugCreateStrategy
- Replace comparisons of marketPrice with 0 by checks if undefined
- Adjust Overlapping Graph to remove percentage above and below when there is no price
    @tiagofilipenunes
    tiagofilipenunes committed May 9, 2024
    Configuration menu
    Copy the full SHA
    63a56eb View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Update src/components/strategies/overlapping/OverlappingStrategyGraph… 

    ….tsx

Co-authored-by: François <francois.guezengar@hotmail.fr>
    @tiagofilipenunes @GrandSchtroumpf
    tiagofilipenunes and GrandSchtroumpf committed May 10, 2024
    Configuration menu
    Copy the full SHA
    9a87f08 View commit details
    Browse the repository at this point in the history

  2. Rename actualMarketPrice and change mean calculation

    @tiagofilipenunes
    tiagofilipenunes committed May 10, 2024
    Configuration menu
    Copy the full SHA
    d874910 View commit details
    Browse the repository at this point in the history

  3. Create variable to check price source is coingecko

    @tiagofilipenunes
    tiagofilipenunes committed May 10, 2024
    Configuration menu
    Copy the full SHA
    5313eb9 View commit details
    Browse the repository at this point in the history

  4. Use user market price in useWarning

    @tiagofilipenunes
    tiagofilipenunes committed May 10, 2024
    Configuration menu
    Copy the full SHA
    5378d0d View commit details
    Browse the repository at this point in the history

  5. Show geomean price on deposit and withdrawal with no external price 

    - Calculate market price percentage inside OverlappingStrategyGraph
- Pass external and old market price in deposit and withdrawal
- Change price source checks and add geometric mean text
    @tiagofilipenunes
    tiagofilipenunes committed May 10, 2024
    Configuration menu
    Copy the full SHA
    5d34472 View commit details
    Browse the repository at this point in the history

  6. Remove isPriceAvailable check from Graph

    @tiagofilipenunes
    tiagofilipenunes committed May 10, 2024
    Configuration menu
    Copy the full SHA
    d3cca1e View commit details
    Browse the repository at this point in the history

  7. Throw error if userMarketPrice is undefined

    @tiagofilipenunes
    tiagofilipenunes committed May 10, 2024
    Configuration menu
    Copy the full SHA
    4d77f81 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Use useMarketPrice directly inside the overlapping strategy graph com… 

    …ponent
    @tiagofilipenunes
    tiagofilipenunes committed May 13, 2024
    Configuration menu
    Copy the full SHA
    a21cc2c View commit details
    Browse the repository at this point in the history

  2. Fix user market price preference for overlapping graph 

    - If disabled, prefer external price over market price
- If enabled, prefer user price over external price
    @tiagofilipenunes
    tiagofilipenunes committed May 13, 2024
    Configuration menu
    Copy the full SHA
    d41f5f0 View commit details
    Browse the repository at this point in the history