Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some function names #415

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Conversation

bytetigers
Copy link
Contributor

fix some function names

Implementation details

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

Signed-off-by: bytetigers <bytetiger@icloud.com>
@bytetigers
Copy link
Contributor Author

Hi, FYI this looks like a bot farming trust. The user has raised 12 PRs in as many minutes, fixing only typos.

hyperium/tonic#1869 vechain/thor#817 sushiswap/sushiswap#1606 ReactiveX/RxJava#7749 https://github.com/UMAprotocol/protocol/pull/4778/files https://github.com/zcash/librustzcash/pull/1494/files harmony-one/harmony#4734 RunOnFlux/flux#1387 https://github.com/gluwa/creditcoin/pull/1688
https://github.com/bandprotocol/chain/pull/415
https://github.com/centrifuge/centrifuge-chain/pull/1963
https://github.com/bcnmy/biconomy-client-sdk/pull/558

First of all, I am not a robot. I submitted all of them manually. Some of the identification and judgment took a lot of time.

I submitted a method to fix the method name to the https://github.com/vechain/thor/pulls project you maintain. If you think it is worthless, you can close it. Please don't think that others are like you and think it is insignificant.

Don't comment under each PR, which reflects your self-righteousness and poor quality.

As the maintainer of this project said, I don't think there is anything wrong with such changes gluwa/creditcoin#1688

@taobun taobun merged commit 9278e9c into bandprotocol:master Sep 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants