Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #1869

Merged
merged 1 commit into from
Aug 19, 2024
Merged

chore: fix some comments #1869

merged 1 commit into from
Aug 19, 2024

Conversation

bytetigers
Copy link
Contributor

Motivation

fix some comments

Solution

Signed-off-by: bytetigers <bytetiger@icloud.com>
@darrenvechain
Copy link

@bytetigers
Copy link
Contributor Author

Hi, FYI this looks like a bot farming trust. The user has raised 12 PRs in as many minutes, fixing only typos.

#1869 vechain/thor#817 sushiswap/sushiswap#1606 ReactiveX/RxJava#7749 https://github.com/UMAprotocol/protocol/pull/4778/files https://github.com/zcash/librustzcash/pull/1494/files harmony-one/harmony#4734 RunOnFlux/flux#1387 gluwa/creditcoin#1688 bandprotocol/chain#415 centrifuge/centrifuge-chain#1963 bcnmy/biconomy-client-sdk#558

First of all, I am not a robot. I submitted all of them manually. Some of the identification and judgment took a lot of time.

I submitted a method to fix the method name to the https://github.com/vechain/thor/pulls project you maintain. If you think it is worthless, you can close it. Please don't think that others are like you and think it is insignificant.

Don't comment under each PR, which reflects your self-righteousness and poor quality.

As the maintainer of this project said, I don't think there is anything wrong with such changes gluwa/creditcoin#1688

Copy link
Collaborator

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes make sense to me, thanks!

@djc djc added this pull request to the merge queue Aug 19, 2024
Merged via the queue into hyperium:master with commit c8754f3 Aug 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants