Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corruption prevention/log #22

Closed
NicoHood opened this issue Dec 24, 2016 · 4 comments
Closed

Corruption prevention/log #22

NicoHood opened this issue Dec 24, 2016 · 4 comments

Comments

@NicoHood
Copy link
Collaborator

NicoHood commented Dec 24, 2016

I just started your tool for my root partition and the shell with the command disappeared (I possibly closed it). I dont know if the backup finished or not. And if it was not finished I am asking myself if snap-sync can detect it, to not produce more corrupted backups.

A logfile of the output would be nice. /var/log/snap-sync maybe. I did not run it as a service.

A detection if more than 2 snap-sync snapshots exist would be nice. the new one was possibly not transmitted correct. --> I checked what happens and it seems that it leaves the corrupted one, because its not tagged:

single | 2450 |       | Fri 23 Dec 2016 09:00:05 PM CET  | root | timeline | timeline                                                  |                                                                 
single | 2451 |       | Fri 23 Dec 2016 10:00:05 PM CET  | root | timeline | timeline                                                  |                                                                 
single | 2452 |       | Fri 23 Dec 2016 10:00:10 PM CET  | root |          |                                                           | 

The problem with this is, that this is never cleaned up. So a tag like "backup_inprogress" would be a way to indicate failed backups. Next time snap-sync can detect this, warn and ask for deletion.

Edit:
Got config in use again after i try to transfer again:

Will backup //.snapshots/2474/snapshot to /run/media/arch/e5b8a2d6-85a1-4640-a659-acb8d6922bd6/backup/E744/root/2474//snapshot
Continue with backup [Y/n]? y
At subvol //.snapshots/2474/snapshot
Config is in use.
@wesbarnett
Copy link
Collaborator

Good idea about the logging. (cf #21)

wesbarnett added a commit that referenced this issue Jan 9, 2017
@wesbarnett
Copy link
Collaborator

I think this is fixed given these commits. Closing.

@NicoHood
Copy link
Collaborator Author

If the script starts it should check for existing "in progress" snapshots and ask for deletion of those. or warn at least. i think that is missing currently.

@wesbarnett wesbarnett reopened this Jan 28, 2017
@wesbarnett wesbarnett changed the title [FR] Corruption prevention/log Corruption prevention/log Jan 28, 2017
@wesbarnett
Copy link
Collaborator

Closing in favor of #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants