Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project collaboration setup #1

Open
barakadanny opened this issue Aug 29, 2022 · 2 comments
Open

Project collaboration setup #1

barakadanny opened this issue Aug 29, 2022 · 2 comments

Comments

@barakadanny
Copy link
Owner

barakadanny commented Aug 29, 2022

Note 🔖

This project is being developed by:

Link to the Project distribution Kanban board

Happy Coding 🥂

@leonardodiasb
Copy link

Required Changes ♻️ ⚠️ 🚦

Hi @barakadanny,

Good job so far!
You still need to work on some issues to start this project, but you are almost there!

mario_ladders

Aspects to improve ♻️

  • Check the comments under the review.
  • I can see that you tried to create your own Kanban board, but for this project, you should implement a copy of this template board. You can follow the steps described in curriculum-tools-copy-projects to implement that.
    -Your board:

image

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.

@mikethreels
Copy link

Hi Team,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants