Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage badge misrepresenting the actual coverage #17

Open
baratgabor opened this issue Feb 22, 2021 · 0 comments
Open

Coverage badge misrepresenting the actual coverage #17

baratgabor opened this issue Feb 22, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@baratgabor
Copy link
Owner

baratgabor commented Feb 22, 2021

The coverage is currently only calculated for the application core, i.e. Application and Domain layers.

This is still highly meaningful, since that covers the actual business operations, but the WebApi and the Infrastructure assembly is excluded, as well as the Angular frontend assembly (WebUI).

Edit: Added unit tests with high coverage for WebApi.

Would be good to communicate this somehow, because currently it can potentially mislead people about the quality of the project, while the frontend in particular has zero testing.

(Sadly Coveralls badges don't provide customizability.)

@baratgabor baratgabor added the enhancement New feature or request label Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant