Remove php 7.2

[codedge]

As php 7.2 is EOL and reading through issue #465 I wanted to give a ping to remove 7.2. IMHO 7.3 could also be removed as it only receives security updates, and just prevents the code base to be updated with property type-hints.

If ok, I can create a PR, lmk.

[finwe]

Let me vote for this as it would make way to allow PHP 8 which is now blocked by other older dependencies.

[codedge]

So who is deciding if that should be done or not? I just want to know if I can create a PR which is then actually being merged 😉

[Sebbo94BY]

PHP 8.0 is already allowed in the develop branch: https://github.com/barbushin/php-imap/blob/develop/composer.json#L26

[finwe]

@Sebi94nbg I am not quite sure this change is enough without change of dependencies. Made the same in my fork and many of them had to be updated for composer to run. finwe@dce42bc

(notice ~8.0 for more elegant 8.1 exclusion)

[finwe]

I am aware this discussion is a bit off-topic here, if needed, please point me to a more suitable place.

[bapcltd-marv]

I get the feeling that it'd be safer to jump from ^7.2 || ^8.0 <8.1 to ^8.1 because of the object type change- i.e. dropping a php version just because it's no longer supported when there's no syntax/code changes that need to be made is unhelpful to people stuck on legacy systems.

[finwe]

That's not possible for reasons I describe above. Let's continue the discussion in a dedicated issue #599

[bapcltd-marv]

this has proved to be quite possible, so php 7.2 is a non-issue pending merge of #598

[Sebbo94BY]

I think, we can slowly get rid of PHP 7.2 and 7.3 starting next year since both versions are end of life now: https://www.php.net/supported-versions.php

I'll try to work on it in Q1/2022. If anyone should be faster: I'll be happy to merge the pull request. :)