Error in code

[joseph-batson]

File: Mailbox.php
Line: 509

            $replace = array(
                '/\s/' => '_',
                '/[^0-9a-zа-яіїє_\.]/iu' => '',
                '/_+/' => '_',
                '/(^_)|(_$)/' => '',
            );

should be

            $replace = array(
                '/\s/' => '_',
                '/[^0-9a-zA-Z_\.]/' => '',
                '/_+/' => '_',
                '/(^_)|(_$)/' => '',
            );

[barbushin]

Why?)

[joseph-batson]

In a previous version that was the regex that was used in method
initMailPart. Just looked wrong to me, if

If this

$replace = array(

'/\s/' => '_',

'/[^0-9a-zа-яіїє_.]/iu' => '',

'/+/' => '',

'/(^)|($)/' => '',

);

is correct let me know.

Thanks,
Joseph Batson
Web Developer
Email: mailto:jbatson@verifysystems.com jbatson@verifysystems.com
Verify Systems, Inc.

---

From: Sergey [mailto:notifications@github.com]
Sent: Friday, July 17, 2015 1:17 AM
To: barbushin/php-imap
Cc: joseph-batson
Subject: Re: [php-imap] Error in code (#86)

Why?)

—
Reply to this email directly or
#86 (comment)
view it on GitHub.
<https://github.com/notifications/beacon/AMvQfvhPDdEFEXOfHnQ_sC8GyBS7td4Mks5
oeJVpgaJpZM4FZfl9.gif>

[Sebbo94BY]

@barbushin this is about this piece of code on L724-L730:

$replace = [
	'/\s/' => '_',
	'/[^0-9a-zа-яіїє_\.]/iu' => '',
	'/_+/' => '_',
	'/(^_)|(_$)/' => '',
];
$fileSysName = preg_replace('~[\\\\/]~', '', $mail->id . '_' . $attachmentId . '_' . preg_replace(array_keys($replace), $replace, $fileName));

In my opinion, I would change it to this regex: /[^\w\.]/iu

• ^ Starting with...
• \w Any word character (letter, number, underscore)
• \. A dot (.)

So \w includes these characters:

• 0-9
• a-z
• A-Z
• _
• яіїє

When you agree, I'll just change this single regex to my suggested solution.

[Sebbo94BY]

Tested the change and all is still working fine and as expected.