Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imap_mime_header_decode may return false #246

Closed
ghost opened this issue May 25, 2018 · 2 comments
Closed

imap_mime_header_decode may return false #246

ghost opened this issue May 25, 2018 · 2 comments
Assignees
Labels
needs investigation This will be tested / debugged or checked out.

Comments

@ghost
Copy link

ghost commented May 25, 2018

In Mailbox::decodeMimeStr the function imap_mime_header_decode is directly called inside the foreach-statement. This causes a "Warning: Invalid argument supplied for foreach()" if imap_mime_header_decode returns false.

To avoid that simply change Mailbox, 708 from:

foreach(imap_mime_header_decode($string) as $element) {
..

to

$elements = imap_mime_header_decode($string);
if(!$elements){
    return '';
}
foreach($elements as $element){
..

Thanks for the good work, love that lib :-)

@Sebbo94BY Sebbo94BY self-assigned this Apr 30, 2019
@Sebbo94BY Sebbo94BY added the needs investigation This will be tested / debugged or checked out. label Apr 30, 2019
@Sebbo94BY
Copy link
Collaborator

This behaviour has been improved. Thanks for reporting this!

Will be included in the next release.

Sebbo94BY added a commit that referenced this issue May 5, 2019
- Updated README
- Move phpunit to require-dev
- Add note about installing dev dependencies in README
- Replaced spaces with tabs
- Added PHPUnit tests for MIME decoding
- Updated formatting of PHPUnit function testParsedDateTimeWithEmptyHeaderDate()
- Issue #209: Function to parse datetime correctly RFC2822
- Issue #280: Added 'Sender' to headers and added additional if-conditions 
- Issue #115: getMail() method returns an object even for nonexistent mail ID
- Issue #273: Added connection check to example
- Issue #227: Added Failed-Recipients to IncomingMailHeader
- Issue #140, #246: Improved exception handling and added PHPUnit test
- Issue #140: Added PHPUnit test for testing ConnectionException
- Issue #140: Improved exception / error handling and improved / added PHPUnit tests
- Issue #154: Added ability to change the imap_search option from SE_UID to SE_FREE and added PHPUnit tests
- Issue #306: Added support for US-ASCII and added ability to disable serverEncoding for searchMailbox()
- Imported missing namespaces to avoid 'unknown class' error messages
- Issue #86: Simplified and improved one replace regex for attachment file names
- Issue #247: Improved grabbing of fromName, fromHost, senderName and senderHost
- Issue #39, #71, #229: Fixed body content gets incorrectly processed as attachments
- Issue #122, #150, #167: Added ability to skip processing of attachments to increase performance, when attachments are not required
- PR #284: Added missing PHPUnit tests
- Issue #122, #150, #167: Lazy load message text and attachments data
@alejobit
Copy link
Contributor

This issue is still present, the function imap_mime_header_decode with the text =?ISO-8859-1?B?QWxlcnRhIEF0cmFwYVB1bnRvczogVGllbmVzIG51ZXZvcyBwdW50b3MgZGlzcG9uaWJsZXMh=?= returns false, breaking the foreach loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs investigation This will be tested / debugged or checked out.
Projects
None yet
Development

No branches or pull requests

2 participants