-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed some issues, improved library and PHPUnit tests #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Sebbo94BY
commented
May 1, 2019
•
edited
Loading
edited
- Updated README
- Move phpunit to require-dev
- Add note about installing dev dependencies in README
- Replaced spaces with tabs
- Added PHPUnit tests for MIME decoding
- Updated formatting of PHPUnit function testParsedDateTimeWithEmptyHeaderDate()
- Issue Incorrect date with time zone #209: Function to parse datetime correctly RFC2822
- Issue Error when empty headers field "from" #280: Added 'Sender' to headers and added additional if-conditions
- Issue getMail() method returns an object even for nonexistent mail ID #115: getMail() method returns an object even for nonexistent mail ID
- Issue Check error connection #273: Added connection check to example
- Issue How can I get the X-Failed-Recipients? #227: Added Failed-Recipients to IncomingMailHeader
- Issue Catch errors #140, imap_mime_header_decode may return false #246: Improved exception handling and added PHPUnit test
- Issue Catch errors #140: Added PHPUnit test for testing ConnectionException
- Issue Catch errors #140: Improved exception / error handling and improved / added PHPUnit tests
- Issue Performance improvement, my solution #154: Added ability to change the imap_search option from SE_UID to SE_FREE and added PHPUnit tests
- Issue office365 setServerEncoding US_ASCII mb_list_encodings #306: Added support for US-ASCII and added ability to disable serverEncoding for searchMailbox()
- Imported missing namespaces to avoid 'unknown class' error messages
- Issue Error in code #86: Simplified and improved one replace regex for attachment file names
- Issue Undefined property: stdClass::$host #247: Improved grabbing of fromName, fromHost, senderName and senderHost
- Issue textPlain is blank, txt is in attachment #39, Message Issue #71, multipart/related #229: Fixed body content gets incorrectly processed as attachments
- Issue Disable attachment storing #122, ignoring attachments when downloading body #150, slow!!!! #167: Added ability to skip processing of attachments to increase performance, when attachments are not required
- PR SPLIT #239:::Skip attachments #284: Added missing PHPUnit tests
- Issue Disable attachment storing #122, ignoring attachments when downloading body #150, slow!!!! #167: Lazy load message text and attachments data
… as attachment based on id
fixes #150 #167 #122 as discussed at #284 instead of trying to avoid loading attachments rather put it off until it is needed. we can do the same for text plain and text html as well, what you don't need won't be retrieved. solution remains non breaking, public lazy load properties are implemented as property magic getter
Function to parse datetime correctly RFC2822 + tests
Added some more information and improved the sample code
Added line break to sample code in order to avoid side-scrolling effect
phpunit is not required in production, only for development.
Move phpunit to require-dev
…D to SE_FREE and added PHPUnit tests
@barbushin please verify and merge, if it's ok from your side as well.
Everything, what changed (eg. ability to change the IMAP search option from This PR solves the in the PR description mentioned issues. |
@barbushin can we merge and release these changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.