-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dird: missing quotes around name when using configure export
#1171
Merged
pstorz
merged 7 commits into
bareos:master
from
alaaeddineelamri:dev/alaaeddineelamri/master/b1145-missing-quotes-director-export
Apr 26, 2022
Merged
dird: missing quotes around name when using configure export
#1171
pstorz
merged 7 commits into
bareos:master
from
alaaeddineelamri:dev/alaaeddineelamri/master/b1145-missing-quotes-director-export
Apr 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alaaeddineelamri
force-pushed
the
dev/alaaeddineelamri/master/b1145-missing-quotes-director-export
branch
from
April 22, 2022 12:03
a214c38
to
0c7dfb3
Compare
bruno-at-bareos
requested changes
Apr 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
…lly. Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
bruno-at-bareos
force-pushed
the
dev/alaaeddineelamri/master/b1145-missing-quotes-director-export
branch
from
April 26, 2022 11:27
01a931b
to
d1e44d1
Compare
bruno-at-bareos
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once green can be merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fix for issue 1445.
configure export
would export name without quotes. This PR fixes the issue.Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-merge
does not report any problemsgit status
should not report modifications in the source tree after building and testingTests