checkpoints: fix performance drop on big volume restores #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arogge
approved these changes
Feb 28, 2023
remove unused `PossibleIncompleteJob` function (cherry picked from commit 03c838f)
Previously, when updating backup checkpoints, DIR would try to update the jobmedia table entries or create a new one in case an update is not possible which in consequence made the jobmedia table entries kind of merged. The change lowered the number of entries in the jobmedia table but had the unwanted consequence of slowing restores in certain situations (restores on big volumes for example). With this change, jobmedia entries will only get created, and checkpoints will add an entry into the jobmedia table instead of updating existing entries. (cherry picked from commit 897129f)
(cherry picked from commit 80f2c52)
(cherry picked from commit 46e9632)
* changed when checkpoints are triggered relative to attribute saving * add extra checks for when to trigger checkpoints (cherry picked from commit 2297d5a)
after jobmedia entry creation (cherry picked from commit f622ade)
(cherry picked from commit bef9631)
(cherry picked from commit 66aac31)
(cherry picked from commit cc1e0c7)
(cherry picked from commit 0448d17)
(cherry picked from commit b270c90)
arogge
force-pushed
the
dev/alaaeddineelamri/bareos-22/backport-1345
branch
from
9fb36b1
to
358b2e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Backport of PR #1345 to bareos-22
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality