Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cats: fix creates, grants and drops postgresql #1502

Conversation

bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Jul 4, 2023

Unfortunately #1466 is missing some code and has a typo. This PR aims to fix that.

  • fix typo for pg_temp schema in create/postgresql.sql
  • add drop instruction for function bareos_frombase64 and decode_lstat
  • add grants instruction for functions

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

- fix typo for pg_temp schema in create/postgresql.sql
- add drop instruction for function bareos_frombase64 and decode_lstat
- add grants execute instructions for functions

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Set ready for merge whenever you're done.

@arogge arogge marked this pull request as draft July 4, 2023 15:21
@arogge arogge removed the draft label Jul 4, 2023
@bruno-at-bareos bruno-at-bareos marked this pull request as ready for review July 4, 2023 19:24
@BareosBot BareosBot merged commit aa0b1e8 into bareos:master Jul 4, 2023
@bruno-at-bareos bruno-at-bareos deleted the dev/bruno/master/cats-ddl-create-drop-fixes branch August 14, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants