Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bareos-triggerjob: fix parameter handling #1708

Merged
merged 3 commits into from Feb 8, 2024
Merged

bareos-triggerjob: fix parameter handling #1708

merged 3 commits into from Feb 8, 2024

Conversation

joergsteffens
Copy link
Member

@joergsteffens joergsteffens commented Feb 7, 2024 •
edited

Fix parameter handling of bareos-triggerjob (contrib)
and improve parameter help string of standard parameter.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)

bruno-at-bareos
bruno-at-bareos requested changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements, there's some questions and changes needed.

contrib/misc/triggerjob/bareos-triggerjob.py Show resolved Hide resolved
contrib/misc/triggerjob/bareos-triggerjob.py Show resolved Hide resolved
python-bareos/bareos/bsock/directorconsole.py Show resolved Hide resolved
@joergsteffens joergsteffens force-pushed the dev/joergs/master/python-contrib branch from 96124d0 to 45b5d97 Compare February 8, 2024 09:54
bruno-at-bareos
bruno-at-bareos approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, everything is now ok.
Please create appropriate backport for 23

@joergsteffens joergsteffens mentioned this pull request Feb 8, 2024
Merged
4 tasks
joergsteffens and others added 3 commits February 8, 2024 14:56
@joergsteffens @BareosBot
python-bareos: argparse: use group
bc5c39c 
To better distinguish between standard connection options
and additional custom options,
use a argument group for the standard options.
@joergsteffens @BareosBot
triggerjob: fix parameter handling
e3de106 
Fixes problems in parameter handling
and apply some changes proposed by pylint.
@BareosBot
Update CHANGELOG.md
5eae80e
@BareosBot BareosBot force-pushed the dev/joergs/master/python-contrib branch from a762867 to 5eae80e Compare February 8, 2024 14:56
@BareosBot BareosBot merged commit 7ab41dc into bareos:master Feb 8, 2024
@joergsteffens joergsteffens deleted the dev/joergs/master/python-contrib branch February 8, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-at-bareos bruno-at-bareos bruno-at-bareos approved these changes

Assignees

@bruno-at-bareos bruno-at-bareos

Labels
requires backport to 23
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joergsteffens @bruno-at-bareos @BareosBot