Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bareos-triggerjob: fix parameter handling #1709

Merged

Conversation

joergsteffens
Copy link
Member

@joergsteffens joergsteffens commented Feb 8, 2024

Backport of PR #1708 to bareos-23

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

Source code quality (if there were changes to the original PR)

Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the job.
Please fix the conflicting files.

Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - Approved

joergsteffens and others added 3 commits February 13, 2024 14:47
To better distinguish between standard connection options
and additional custom options,
use a argument group for the standard options.

(cherry picked from commit 098cff2)
Fixes problems in parameter handling
and apply some changes proposed by pylint.

(cherry picked from commit 45b5d97)
@BareosBot BareosBot force-pushed the backport/bareos-23/python-contrib branch from 81fb168 to ebde34a Compare February 13, 2024 14:47
@BareosBot BareosBot merged commit e52dbae into bareos:bareos-23 Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants