Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Clean up error handling in LDAP plugin, fix dependencies #1717

Merged

Conversation

sebastianlederer
Copy link
Collaborator

@sebastianlederer sebastianlederer commented Feb 21, 2024

Thank you for contributing to the Bareos Project!

Bugfix: Clean up error handling in LDAP plugin

  • handle referrals in search results
  • better error reporting when using incorrect base DN
  • refactor reporting of LDAP exceptions
  • replace old-style % operator with format()
  • Debian package build: fix dependencies for python-ldap

Please check

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

Sebastian Lederer and others added 5 commits March 7, 2024 19:08
- handle referrals in search results
- better error reporting when using incorrect base DN
- refactor reporting of LDAP exceptions
- replace old-style % operator with format()
- Debian package build: fix dependencies for python-ldap

Fixes: bareos#1599: FD LDAP Plugin has broken dependencies on Debian 11+
Accept SYSTEMTEST_LDAP_ADDRESS with port number, like
SYSTEMTEST_LDAP_ADDRESS=127.0.0.1:389
Also test how the plugin behaves with wrong credentials.
@sebastianlederer sebastianlederer force-pushed the dev/slederer/ldap-plugin-cleanup branch from 7e4dfde to e2561d5 Compare March 7, 2024 18:09
@BareosBot BareosBot merged commit f719acf into bareos:master Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants