Bugfix: Clean up error handling in LDAP plugin, fix dependencies #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-at-bareos
approved these changes
Mar 12, 2024
- handle referrals in search results - better error reporting when using incorrect base DN - refactor reporting of LDAP exceptions - replace old-style % operator with format() - Debian package build: fix dependencies for python-ldap Fixes: bareos#1599: FD LDAP Plugin has broken dependencies on Debian 11+ (cherry picked from commit 430042d)
(cherry picked from commit a61559c)
Accept SYSTEMTEST_LDAP_ADDRESS with port number, like SYSTEMTEST_LDAP_ADDRESS=127.0.0.1:389 (cherry picked from commit 9c770b0)
Also test how the plugin behaves with wrong credentials. (cherry picked from commit 81226f2)
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
BareosBot
force-pushed
the
backport/bareos-23/ldap-plugin-cleanup
branch
from
d4fd1ac
to
c814724
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #1717 to bareos-23
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.Source code quality (if there were changes to the original PR)
Backport quality