dbcheck: fix dbcheck crash if password is not set in catalog resource #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstorz
approved these changes
Mar 12, 2024
sebsura
force-pushed
the
backport/bareos-23/fix-dbcheck-missing-pw-crash
branch
from
d9ee3cb
to
65a1b9e
Compare
We now set the strings to be empty if the value it shouldve been assigned is null. This can happen if the configuration is missing. (cherry picked from commit 7db1d28)
There is very little reason for this debug message to have level 20. (cherry picked from commit 0d8d1bb)
(cherry picked from commit aa6c72a)
I added some files that specifically have names containing
< (less than)
> (greater than)
: (colon)
" (double quote)
/ (forward slash)
\ (backslash)
| (vertical bar or pipe)
? (question mark)
* (asterisk)
as there are illegal in normal windows paths.
(cherry picked from commit aa6363b)
BareosBot
force-pushed
the
backport/bareos-23/fix-dbcheck-missing-pw-crash
branch
from
34bc333
to
3117b8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #1710 to bareos-23
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.Source code quality (if there were changes to the original PR)
Backport quality