New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cats: fixes BigSqlQuery header fetching #1746
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I requested some changes below. I think we can also easily add a test for this.
Having the tmp/file-list
contain tmp/data
twice is enough to get over the 100 file mark. Afterwards we can check if a list files
outputs the correct headers.
fd4431f
to
bb0d3cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some feedback to your test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work. I added some comments. Feel free to ignore them.
f3cef00
to
e1ad238
Compare
BigSqlQuery fetches data in 100 row chunks. This change makes sure, that subsequent chunks also have valid header information. Fixes: #1007: JSON API: 'list files' returns malformed json Co-authored-by: Sebastian Sura <124262655+sebsura@users.noreply.github.com>
Co-authored-by: Sebastian Sura <124262655+sebsura@users.noreply.github.com>
b70535b
to
3888a86
Compare
BigSqlQuery fetches data in 100 row chunks.
This change makes sure, that subsequent chunks
also have valid header information.
Fixes: https://bugs.bareos.org/view.php?id=1007 JSON API: 'list files' returns malformed json
OP#5753
Thank you for contributing to the Bareos Project!
Backport of PR #0000 to bareos-2x (remove this line if this is no backport; for backport use cherry-pick -x)
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-tool
to have some simple automated checks run and a proper changelog record added.General
Check backport lineSource code quality
Tests