Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cats: fixes BigSqlQuery header fetching #1750

Merged

Conversation

joergsteffens
Copy link
Member

@joergsteffens joergsteffens commented Mar 27, 2024

Backport of PR #1746 to bareos-22

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

Source code quality (if there were changes to the original PR)
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

Backport quality

BigSqlQuery fetches data in 100 row chunks.
This change makes sure, that subsequent chunks
also have valid header information.

Fixes: bareos#1007: JSON API: 'list files' returns malformed json

Co-authored-by: Sebastian Sura <124262655+sebsura@users.noreply.github.com>
(cherry picked from commit 2168ccd)
Co-authored-by: Sebastian Sura <124262655+sebsura@users.noreply.github.com>
(cherry picked from commit e1ad238)
Copy link
Contributor

@sebsura sebsura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@BareosBot BareosBot merged commit 653986f into bareos:bareos-22 Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants