-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Windows Debug-Build into Release-Build #858
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The matrix.yml file is not correct.
x86_64: | ||
- bareos | ||
- python-bareos | ||
"4.4": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here is something missing, probably
Univention:
5d17115
to
be0a736
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to add a line to the CHANGELOG that the two windows builds were merged and only one Installer is now available for windows 32 and for windows 64.
dd8bae4
to
b9c7755
Compare
I triple-checked that all distros are built, all files are still produced as desired (i.e. no webui tarballs) and added the CHANGELOG record you requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, looks good to me. You might want to squash the last two commits.
Previously there were two packages built, one contained the sourcecode and the other one didn't. Now we always add the sourcecode to the installer package, so people can decide at install-time if they want to install the sources or not.
9eca2b5
to
e7b5a2d
Compare
As the difference between debug and release for Windows is the shipping of the sourcecode only, this PR merges both packages into one.
The Sourcecode is now an optional component that can be selected at install-time.
To reconfigure the builds, this PR also adds a .matrix.yml that will tell Jenkins to only do the release-builds in the future.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-merge
does not report any problemsgit status
should not report modifications in the source tree after building and testing