also look for "author" property on a top-level "h-feed" #4
Conversation
| @@ -222,6 +231,7 @@ function flattenMicroformats(array $mfs) { | |||
|
|
|||
| function findMicroformatsByType(array $mfs, $name, $flatten = true) { | |||
| return findMicroformatsByCallable($mfs, function ($mf) use ($name) { | |||
| if(!array_key_exists('type', $mf)) return false; | |||
There was a problem hiding this comment.
What is this protecting against? A microformat structure iterated over by findMicroformatsByCallable should never not have a type key. If you’ve come across a situation where that does happen, please let me know where so I can fix it!
Also, this sort of check is what isMicroformat(array $mightBeAMicroformat) is for.
There was a problem hiding this comment.
I think that's just me being overly cautious about stuff. I've removed it from the PR.
|
Thanks for the PR! Good catch, I can’t believe this wasn’t already in there :) Apart from the query raised above, this looks good to me. I’m currently on the fence about whether to put network IO side-effect creating stuff in php-mf-cleaner to enable a full authorship implementation, or to put it in another package. For the moment it can live in here. |
|
After you merge this can you do a new tag for packagist? |
let me know what you think of this