Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Fix label guidance #841

Closed
kelliedesigner opened this issue May 2, 2019 · 1 comment
Closed

Fix label guidance #841

kelliedesigner opened this issue May 2, 2019 · 1 comment
Assignees
@kelliedesigner
Labels
type: bug

Comments

@kelliedesigner
Copy link
Contributor

kelliedesigner commented May 2, 2019 •
edited
Loading

Guidance is missing more explicit implementation how to positional labels and inputs.
https://design-system.barnardos.org.uk/patterns/gathering-information/#asking-for-names

Asking for a name has been implemented differently from the design system in products.

Screen Shot 2019-05-02 at 13 36 07

Address has been implemented differently from the design system in products.
Screen Shot 2019-05-09 at 15 42 11

Current behaviour
Labels for names are positioned below the inputs and styled as hint text

Expected behaviour
Labels for names are positioned above the inputs and treated as labels
@kelliedesigner kelliedesigner self-assigned this May 2, 2019
@kelliedesigner kelliedesigner changed the title Fix asking for name guidance Fix label guidance May 9, 2019
@kelliedesigner
Copy link
Contributor Author

This has already been addressed in #845 and #847

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kelliedesigner kelliedesigner

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kelliedesigner