-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebases, not merges. #58
Comments
I don't think this should be the default, but having the option sounds good. |
We had some additional conversation about this on Servo at: |
I'm personally pro on a Major contributors already have Newbies usually have PRs that should be squashed to a single commit and need the most handling, which This just leaves complex wild-card contributions, which take long enough that the extra roundtrip isn't a big deal IMHO. |
A decision about squashing does not necessarily need to block moving to rebases, but note that git rebase has an |
See servo#19 |
Allow configuring database location
Merge commits are awful for code history. It would be better to rebase PRs and preserve a linear history. This would probably also mean disallowing merge commits in PR branches. The
r=
note could probably be added to all commits rather than the merge commit.The text was updated successfully, but these errors were encountered: