Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebases, not merges. #58

Closed
Ms2ger opened this issue Feb 22, 2015 · 5 comments
Closed

Rebases, not merges. #58

Ms2ger opened this issue Feb 22, 2015 · 5 comments

Comments

@Ms2ger
Copy link

Ms2ger commented Feb 22, 2015

Merge commits are awful for code history. It would be better to rebase PRs and preserve a linear history. This would probably also mean disallowing merge commits in PR branches. The r= note could probably be added to all commits rather than the merge commit.

@Manishearth
Copy link
Contributor

I don't think this should be the default, but having the option sounds good.

@larsbergstrom
Copy link

We had some additional conversation about this on Servo at:
servo/servo#1468

@Gankra
Copy link
Contributor

Gankra commented Feb 28, 2015

I'm personally pro on a @bors squash flag.

Major contributors already have r+ rights, so they can squash and r=reviewer themselves, so that's not a concern.

Newbies usually have PRs that should be squashed to a single commit and need the most handling, which @bors squash r+ handles perfectly.

This just leaves complex wild-card contributions, which take long enough that the extra roundtrip isn't a big deal IMHO.

@Ms2ger
Copy link
Author

Ms2ger commented Feb 28, 2015

A decision about squashing does not necessarily need to block moving to rebases, but note that git rebase has an --autosquash flag that folds commits made with commit --fixup.

@cgwalters
Copy link

See servo#19

alexcrichton pushed a commit to alexcrichton/homu that referenced this issue Nov 30, 2016
Allow configuring database location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants