Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sake server: Trackmania Wii tables added #472

Merged
merged 1 commit into from
Mar 6, 2018
Merged

Sake server: Trackmania Wii tables added #472

merged 1 commit into from
Mar 6, 2018

Conversation

barronwaffles
Copy link
Owner

@barronwaffles barronwaffles commented Feb 26, 2018

Tables used by Trackmania Wii for user statistics and custom track sharing.

I need to spend time investigating the function of the row field found in player and solo, but this dataset currently allows the game to function without issue.

Ready to be reviewed & merged.

EDIT : Looks like my editor flushed dead whitespace, can amend commit if required.

@sepalani
Copy link
Collaborator

sepalani commented Mar 5, 2018

Ping @polaris-

Sounds good to me.

Dead whitespace doesn't bother me that much and on top of that git has an option to ignore them -w when using git diff:
https://github.com/polaris-/dwc_network_server_emulator/pull/472/files?w=1

@polaris-
Copy link
Collaborator

polaris- commented Mar 6, 2018

Down with unnecessary whitespace I say. I use the same settings too.

Anyway, LGTM. Thanks for the ping. (I only check Github during work hours now, and I check mentions frequently, so it's the best way to get me to look at something. Ping me again if you haven't heard anything in a week or two since I probably saw it and forgot).

@polaris- polaris- merged commit 4a3beaf into barronwaffles:master Mar 6, 2018
@barronwaffles barronwaffles deleted the trackmania-sake branch March 6, 2018 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants