Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep world as in UQM #1

Closed
GoogleCodeExporter opened this issue Jan 17, 2016 · 2 comments
Closed

Keep world as in UQM #1

GoogleCodeExporter opened this issue Jan 17, 2016 · 2 comments

Comments

@GoogleCodeExporter
Copy link

Every modification to the code should preserve the original world. That means 
random numbers need to be tested against the same values, or shifted if tested 
against a RESOLUTION_FACTOR dependent value.

A critic example of this as of revision r180 happens in system generation : 
planets and moons are not the same in uqmhd and in vanilla UQM. First I thought 
it was due to SCALE_RADIUS and its companions (and they did have an influence), 
but there seems to be something else I can't put my finger on.

Original issue reported on code.google.com by benjamin...@free.fr on 18 Jan 2011 at 12:52

@GoogleCodeExporter
Copy link
Author

Problem solved in r181, the additional EARTH_WORLD was messing with the choice 
of planet types. Special world types should be added at the end of the planet 
types enum and of planet_array.

Issue remains as preserving the world has to be kept in mind.

Original comment by benjamin...@free.fr on 26 Jan 2011 at 9:46

@GoogleCodeExporter
Copy link
Author

Original comment by dczanik@gmail.com on 24 Dec 2012 at 12:57

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant