Only allow certain types to be attached

[panosl]

A patch that allows users to specify the type of files that can be attached:

ATTACHMENTS_ALLOWED_TYPES = '.jpg .png .jpeg .gif .bmp'

'' is special and everything can be attached.

http://panos.solhost.org/temp/allowed_types.patch

[bartTC]

I don't like "" for "everything". None as a default value makes more sense.

Why raising an IntegrityError and overwriting the save method? It's already checked in the form.

[panosl]

I'll switch to None :)

As for overriding the save() method, there we have model validation, while in the form it only checks on the upload form. You can still attach other types from shell etc.

[panosl]

What should '' mean? If a user chooses to set:

ATTACHMENTS_ALLOWED_TYPES = ''

[bartTC]

I dont see the need for validation on model level, if the admin does that from the shell, he should take care of it.

I'm fine with the form validation but I have some minor nits how it's currently done. I try to add this feature asap and leave that file open.

[panosl]

Fine, let's ditch the validation at the model level :)

[panosl]

I've published a branch[1] on launchpad which includes this update and a way to limit the total size of attachments per model here:

https://code.launchpad.net/~panosl/+junk/django-attachments

[bartTC]

I didn't heard of a need for this in teh past, I'm going to close this. Thank you.

[dmarcelino]

@bartTC I have a similar albeit different requirement. Is there currently a way to restrict which file types can be attached (globally or per model/form)? If not can you point me to a way to work around it?