Search not working with Promise

[lauritzsh]

Hey, great library. Nice with automatic rate limiting.

Database searching with Promise is not working for me however. For example

db.search('skrillex', { type: 'label' }, (err, res) => {
  console.log(res);
})

is returning just five items like their own API with https://api.discogs.com/database/search?q=skrillex&type=label&token=[redacted]. However if I am using a Promise like

db.search('skrillex', { type: 'label' })
  .then(console.log)

I get 870 items with all sorts of different results. Basically everything with Skrillex I assume.

Should it instead of this

if(arguments.length <= 2){
	if(typeof params === 'function'){ callback = params; } // No extra search params, the callback is the second function param
}else{
	obj = params;
}

just be a simple && check

if(arguments.length <= 2 && typeof params === 'function'){
	callback = params; // No extra search params, the callback is the second function param
}else{
	obj = params;
}

since the length is <= 2 but params is not a function, obj should just be set to params. I will create a pull request for you, just checking first that the logic is sound.

[bartve]

It's slightly more subtle. This way obj will end up being undefined when you just add 1 param. Will add a fix today. Thanks for reporting!

[lauritzsh]

That's true, good catch. I see you have fixed it, very nice! Thank you.