Attempt at adapting example to be usable without Bokeh. Fixes #174 #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocks into MNIST-without-Bokeh Merged with Upstream
…dified tests too
| @@ -24,7 +24,7 @@ | |||
| from blocks.main_loop import MainLoop | |||
|
|
|||
|
|
|||
| def main(save_to, num_epochs): | |||
| def main(save_to, num_epochs, no_bokeh): | |||
There was a problem hiding this comment.
You should probably give a default, no_bokeh=True here as well, but make sure that the tests use no_bokeh=True so that it still gets tested on Travis.
|
The errors are ocurring because you've changed the signature of |
| @@ -24,7 +24,15 @@ def test_sqrt(): | |||
| def test_mnist(): | |||
| skip_if_not_available(modules=['bokeh']) | |||
| with tempfile.NamedTemporaryFile() as f: | |||
| mnist_test(f.name, 1) | |||
| mnist_test(f.name, 1, True) | |||
There was a problem hiding this comment.
Probably just run this test once with Bokeh, it'll just slow down the test suite to run it twice, and we don't really gain much from it.
There was a problem hiding this comment.
I agree. Changes made, submitted PR
bartvm
added a commit
that referenced
this pull request
Apr 1, 2015
Attempt at adapting example to be usable without Bokeh. Fixes #174
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.