Add check in Selector.get_params for path uniqueness #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -177,6 +177,12 @@ def recursion(brick): | |||
| for child in brick.children: | |||
| for path, param in recursion(child).items(): | |||
| new_path = Path([Path.BrickName(brick.name)]) + path | |||
| if new_path in result: | |||
| raise ValueError( | |||
| "name collision while retrieving parameters (" + | |||
There was a problem hiding this comment.
Can you please split this error message into a concise one and a verbose one like we do it here?
|
LGTM except for the error message. |
|
Oops, forgot about it! |
rizar
added a commit
that referenced
this pull request
Apr 29, 2015
Add check in Selector.get_params for path uniqueness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This concerns issue #480. It's not a complete solution, but at least
Selectorwon't do the wrong thing silently anymore.