Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with "legacy" python #1

Closed
dmitriy-serdyuk opened this issue Feb 8, 2016 · 4 comments
Closed

Incompatible with "legacy" python #1

dmitriy-serdyuk opened this issue Feb 8, 2016 · 4 comments

Comments

@dmitriy-serdyuk
Copy link

I wasn't able to install Mimir using python 2.7. The first problem was that there are unicode characters in setup.py which can be easily fixed by a magical comment. Another problem that there's no collections.abc in python 2.7 and I'm not sure how to fix it.

@bartvm bartvm closed this as completed in 91a018e Feb 8, 2016
@bartvm
Copy link
Owner

bartvm commented Feb 8, 2016

Thanks for letting me know! Does it work now?

@dmitriy-serdyuk
Copy link
Author

Thanks, it works!

@bartvm
Copy link
Owner

bartvm commented Feb 8, 2016

Please let me know what you think! Haven't gotten any feedback yet.

@dmitriy-serdyuk
Copy link
Author

I just had time to play with it a little. At first glance I was a little scared about lots of C code. But actually, I like the interface! It's extremely concise.

I far as I can see, this logger is not picklable. I know, that it doesn't much sense to pickle it. It would be useful to provide a method which copies the gziped log to the pickled file. What do you think?

@bartvm bartvm mentioned this issue Feb 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants