You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have a PR in process for this but I wanted to gut check a bit before dumping much more time into it.
I am running Kamal on a NAS for personal projects. VM is an option but that is resource intensive for little benefit. Consequently, I am using a shared Docker instance that manages my media library, personal registry, multiplayer servers, etc. Because Kamal's use of Traefik monitors Docker aggressively by default, I get a huge amount of irrelevant chatter in my logs with all the other services I'm running. No problem, I can just just set providers.docker.exposedbydefault: false in the Traefik args and whitelist containers individually with the traefik.enabled=true label.
The confusion comes in with the healthcheck container. I can absolutely set labels for the healthcheck role in the web container or use other configurational workarounds, however, it seems counterintuitive to me that the healthcheck configuration does not directly support labels. The other container-based configs do, but not healthcheck.
Anyway, tl;dr, I think it makes sense to add label support directly to healthcheck. Totally understand if this change would cater too directly to niche use cases, but I'm going to plug away at a PR unless there's strong opposition to this approach.
The text was updated successfully, but these errors were encountered:
I have a PR in process for this but I wanted to gut check a bit before dumping much more time into it.
I am running Kamal on a NAS for personal projects. VM is an option but that is resource intensive for little benefit. Consequently, I am using a shared Docker instance that manages my media library, personal registry, multiplayer servers, etc. Because Kamal's use of Traefik monitors Docker aggressively by default, I get a huge amount of irrelevant chatter in my logs with all the other services I'm running. No problem, I can just just set
providers.docker.exposedbydefault: false
in the Traefik args and whitelist containers individually with thetraefik.enabled=true
label.The confusion comes in with the healthcheck container. I can absolutely set labels for the healthcheck role in the web container or use other configurational workarounds, however, it seems counterintuitive to me that the healthcheck configuration does not directly support labels. The other container-based configs do, but not healthcheck.
Anyway, tl;dr, I think it makes sense to add label support directly to healthcheck. Totally understand if this change would cater too directly to niche use cases, but I'm going to plug away at a PR unless there's strong opposition to this approach.
The text was updated successfully, but these errors were encountered: