Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Healthcheck container labeling #676

Closed
tumes opened this issue Feb 10, 2024 · 1 comment
Closed

Healthcheck container labeling #676

tumes opened this issue Feb 10, 2024 · 1 comment

Comments

@tumes
Copy link

tumes commented Feb 10, 2024

I have a PR in process for this but I wanted to gut check a bit before dumping much more time into it.

I am running Kamal on a NAS for personal projects. VM is an option but that is resource intensive for little benefit. Consequently, I am using a shared Docker instance that manages my media library, personal registry, multiplayer servers, etc. Because Kamal's use of Traefik monitors Docker aggressively by default, I get a huge amount of irrelevant chatter in my logs with all the other services I'm running. No problem, I can just just set providers.docker.exposedbydefault: false in the Traefik args and whitelist containers individually with the traefik.enabled=true label.

The confusion comes in with the healthcheck container. I can absolutely set labels for the healthcheck role in the web container or use other configurational workarounds, however, it seems counterintuitive to me that the healthcheck configuration does not directly support labels. The other container-based configs do, but not healthcheck.

Anyway, tl;dr, I think it makes sense to add label support directly to healthcheck. Totally understand if this change would cater too directly to niche use cases, but I'm going to plug away at a PR unless there's strong opposition to this approach.

@tumes
Copy link
Author

tumes commented Feb 10, 2024

Nevermind, not traefic's fault, I had some other configurational issues. Closing.

@tumes tumes closed this as completed Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant