Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Updating remote builder host in config.yaml doesn't update endpoint in Docker context #90

Closed
kjellberg opened this issue Mar 7, 2023 · 4 comments · Fixed by #831
Labels

Comments

@kjellberg
Copy link
Contributor

kjellberg commented Mar 7, 2023

I had to run docker context remove <context> first, before running mrsk deploy again. But I feel that when updating config values for the remote, the docker context should update as well?

before

app: foo
builder:
  remote:
    arch: amd64
    host: ssh://root@***
$ docker context ls
NAME                                  DESCRIPTION                                       DOCKER ENDPOINT                                ERROR
default *                             Current DOCKER_HOST based configuration           unix:///var/run/docker.sock                    
desktop-linux                                                                           unix:///Users/rasmus/.docker/run/docker.sock   
mrsk-app-native-remote-amd64   mrsk-app-native-remote amd64 native host   ssh://root@***

after

builder:
  remote:
    arch: amd64
    host: ssh://changed-user-to-something-else-than-root@***
$ docker context ls
NAME                                  DESCRIPTION                                       DOCKER ENDPOINT                                ERROR
default *                             Current DOCKER_HOST based configuration           unix:///var/run/docker.sock                    
desktop-linux                                                                           unix:///Users/rasmus/.docker/run/docker.sock   
mrsk-app-native-remote-amd64   mrsk-app-native-remote amd64 native host   ssh://root@***
@calmyournerves
Copy link
Contributor

calmyournerves commented Mar 7, 2023

Stumbled upon this too. As a workaround, mrsk build remove seems to work too.

@PabloC
Copy link

PabloC commented May 4, 2023

Me too. Thanks for this!

@russ
Copy link

russ commented Aug 7, 2023

I also ran into this problem. I'm using the stages feature and stumbled across it not updating the ip address of the machine. Very difficult to debug as I thought there was a cache lying around somewhere.

@mvanholstyn
Copy link

I hit this today as well. Still appears to be an active issue in the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants