2.0 #55

javan · 2016-03-17T20:25:27Z

Adds i18n support (branched from I18n #53)
Uses MutationObserver instead of listening for various Turbolinks and jQuery events
Allows updating a single element with LocalTime.process(element)
Refactors code into multiple files, logical pieces

Todo:

Update README
Drop coffee-rails dependency, bundle compiled local-time.js instead
Publish npm package

Fixes #54
Fixes #56
Fixes #60
Fixes #63
Fixes #66
Fixes #70
Fixes #71
Closes #49
Closes #50
Closes #53

grk · 2016-05-18T09:31:34Z

I was testing this branch because we need I18n support, and I ran into an issue with PageObserver. It's observing on document.body, but turbolinks throws out the body and replaces it with a new one, so no callbacks were being fired. A quick fix would be to observe on document.body.parentElement (so <html>), but I'm not sure if that's the right way.

Do you have any suggestions how to work around that? Or am I doing something wrong?

javan · 2016-05-29T21:11:32Z

@grk Fixed in 9fae425. Mind giving it a try?

grk · 2016-05-31T10:42:05Z

@javan yes, this fixes the problem. Thanks!

brandonhilkert · 2016-07-14T19:12:28Z

Hi there! Thanks so much for this gem. We're using with Rails 5 and it's not working with the new Turbolinks b/c of the page:change. This looks like it'll do the trick. Was curious if you're going to release soon or if there was something I could do to help the cause. Thanks again 👍

javan · 2016-07-14T19:44:16Z

Hey @brandonhilkert, thanks!

I'd like to explore using Date#toLocaleString (and Date#toLocaleDateString, Date#toLocaleTimeString) to localize timestamp formats natively, and to avoid the need for defining translations client side where possible. I'm not sure it will pan out, but it's worth an investigation.

Other than that, I think this branch is stable for use and could be shipped soon. Just need to polish the docs.

brandonhilkert · 2016-07-14T19:57:09Z

@javan Sounds good! Branch worked well locally, I'll go with that for now. Curious was Basecamp 3 is using for local time display if it's not this...

javan · 2016-07-14T20:08:25Z

Basecamp 3 is running on #49 and using its own MutationObserver wrapper to process elements:

BC.observe 'time[datetime]', (element) ->
  LocalTime.updateElement(element)

This branch obviates it by incorporating a MutationObserver. We could switch over and just haven't gotten around to it.

Using this fantastic gem: https://github.com/basecamp/local_time ⚠️ Using a pre-release version (which seems quite stable): basecamp/local_time#55

akashagarwal7 · 2016-11-05T03:53:26Z

Uncaught TypeError: LocalTime.relativeTimeAgo is not a function
This error didn't show up in the master branch. I use this function on the client side to render data.

…orted. Restores IE 9-10 support.

Also fixes handling mutations that replace the entire <body>

…ctly

javan · 2017-08-07T15:35:05Z

@akashaggarwal7, you can create LocalTime.RelativeTime instances directly now. See relative_time.coffee for its full API.

brandonhilkert · 2017-08-07T18:42:57Z

Thanks for this! ☮️

The branche 2_0 has been deleted and merged basecamp/local_time#55 (comment) It was not possible to build the projet with the gemfile like before.

This was referenced Mar 17, 2016

Listen for turbolinks:load event #54

Closed

I18n #53

Closed

javan mentioned this pull request May 28, 2016

LocalTime fails to initialize when loaded via <script async> #58

Closed

djch added a commit to djch/daybook that referenced this pull request Sep 5, 2016

Update dates to render with local_time

b235d3f

Using this fantastic gem: https://github.com/basecamp/local_time ⚠️ Using a pre-release version (which seems quite stable): basecamp/local_time#55

javan mentioned this pull request Oct 10, 2016

Time zone incorrect #41

Closed

javan mentioned this pull request Nov 3, 2016

The gem is slow in converting #63

Closed

schneems mentioned this pull request May 31, 2017

Add email time of day preference codetriage/CodeTriage#530

Merged

kevcha and others added 15 commits August 4, 2017 13:43

Add i18n support

400ffa9

Update README.md with i18n support

c8efed1

Break into separate files, trim some fat

180e19e

Drop Turbolinks event handler and replace with a MutationObserver

2128d81

Extract PageObserver

122835c

Selector needn't be configurable

be24d78

pageUpdated -> pageUpdateObserved

4fb96cd

Rework i18n and reorganize files

fc93a4a

Avoid direct Date.parse manipulation

d02484b

Style

916c644

Refactor RelativeTime, uncapitalize non-weekday strings

3632b2b

Fall back to translation of default locale

6500f43

Typo

3352e6f

Reorganize translations

8b9798a

Configure abbreviated day and month names

ef5c01d

javan added 8 commits August 4, 2017 13:43

Add LocalTime.run and LocalTime.process

3dc6706

Create controller on demand

f3e7821

Config timer interval

48030e8

Fall back to DOMNodeInserted handler when MutationObserver isn't supp…

930c35a

…orted. Restores IE 9-10 support.

Ensure all code is loaded before installing

6668a62

Only act on mutations that contain significant <time> elements

2bda4c7

Also fixes handling mutations that replace the entire <body>

Defer install to ensure the DOM is fully loaded early IEs

4152c29

Fix adding inner elements to array

a2cf4a5

javan force-pushed the 2-0 branch from 7cf181e to 66164e3 Compare August 4, 2017 20:48

javan added 8 commits August 4, 2017 16:49

Freshen up test rig

4702099

.js.coffee → .coffee

6c3b840

Adjust browser list for CI tests

66164e3

Prepare local-time JavaScript module

7dea8e7

Optimize LocalTime.start()

3d96a71

Make default time and date formats configurable

7013aa9

Remove unused variable

7b60d1d

Include compiled local-time.js to support installing from GitHub dire…

b898fcf

…ctly

javan force-pushed the 2-0 branch from e0564d2 to 1bc9f6c Compare August 7, 2017 13:39

javan added 5 commits August 7, 2017 09:41

Update README

1bc9f6c

Bump Sauce Labs plugin

759587c

Local Time 2.0.0

ab35a47

Adjust Sauce Labs config

fc1e153

Adjust Travis CI config

ad6c2df

javan merged commit 124ece3 into master Aug 7, 2017

javan deleted the 2-0 branch August 7, 2017 14:54

benoittgt mentioned this pull request Aug 9, 2017

Switch to local time 2.0 rather than 2_0 branch codetriage/CodeTriage#607

Merged

foucist mentioned this pull request Sep 28, 2018

Should be able to translate names of months and days like I18n.localize #57

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2.0 #55

2.0 #55

javan commented Mar 17, 2016 •

edited

Loading

grk commented May 18, 2016

javan commented May 29, 2016

grk commented May 31, 2016

brandonhilkert commented Jul 14, 2016

javan commented Jul 14, 2016

brandonhilkert commented Jul 14, 2016

javan commented Jul 14, 2016

akashagarwal7 commented Nov 5, 2016 •

edited

Loading

javan commented Aug 7, 2017

brandonhilkert commented Aug 7, 2017

2.0 #55

2.0 #55

Conversation

javan commented Mar 17, 2016 • edited Loading

grk commented May 18, 2016

javan commented May 29, 2016

grk commented May 31, 2016

brandonhilkert commented Jul 14, 2016

javan commented Jul 14, 2016

brandonhilkert commented Jul 14, 2016

javan commented Jul 14, 2016

akashagarwal7 commented Nov 5, 2016 • edited Loading

javan commented Aug 7, 2017

brandonhilkert commented Aug 7, 2017

javan commented Mar 17, 2016 •

edited

Loading

akashagarwal7 commented Nov 5, 2016 •

edited

Loading