Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

! char in ${!var} shows as invalid #43

Closed
hirenvadalia opened this issue May 27, 2018 · 7 comments
Closed

! char in ${!var} shows as invalid #43

hirenvadalia opened this issue May 27, 2018 · 7 comments
Assignees
Labels
bug Something isn't working grammar bug Issues related to the bash grammar

Comments

@hirenvadalia
Copy link

I am using Bash IDE in VSCode and below code shows as invalid code while it is valid code

TEST_VAR=1
TEST_VAR1=1
declare -a list_of_variables=("TEST_VAR" "TEST_VAR1")
for var in ${list_of_variables[@]}
do
	echo "${var}=${!var}"
done

When I hover over ! char then it show 'Failed to parse expression' in tooltip

@skovhus
Copy link
Collaborator

skovhus commented May 27, 2018

Thanks for reporting this.

Wondering if this is an issue in the treesitter parser or related to the bash IDE. 🤔

@mads-hartmann
Copy link
Collaborator

This is definitely a grammar problem. I'll try to update to 0.11.2 and see if it's still an issue there :)

@mads-hartmann mads-hartmann self-assigned this May 27, 2018
@mads-hartmann mads-hartmann added the bug Something isn't working label May 27, 2018
@hirenvadalia
Copy link
Author

Hey @mads-hartmann Any update on this?

@skovhus
Copy link
Collaborator

skovhus commented Jun 7, 2018

I tried upgrading to the latest version tree-sitter-bash@0.11.2, but I still see this issue.

Might be related to tree-sitter/tree-sitter-bash#18

@hirenvadalia would be great if you can create an issue here https://github.com/tree-sitter/tree-sitter-bash

@achekulaev
Copy link

Yes, the issue is still there.

@ChristinWhite
Copy link

ChristinWhite commented Jul 27, 2018

I opened an issue for this problem: tree-sitter/tree-sitter-bash#21

@skovhus skovhus added the grammar bug Issues related to the bash grammar label Aug 2, 2018
@skovhus
Copy link
Collaborator

skovhus commented Aug 2, 2018

@christopherdwhite thanks for creating the issue in tree-sitter-bash!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working grammar bug Issues related to the bash grammar
Projects
None yet
Development

No branches or pull requests

5 participants