Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Massive refactor for clean up required #2

Open
bashleigh opened this issue Dec 22, 2020 · 2 comments
Open

Massive refactor for clean up required #2

bashleigh opened this issue Dec 22, 2020 · 2 comments
Assignees
@bashleigh
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@bashleigh
Copy link
Owner

I built this in a rush, the original I wrote on a plane, this version was written on a train. Yea it wasn't that extravigant. But the codebase is seriously poor. Needs more than prettier. Could use some help but it is a bit... ...my shitty mess 😂
@bashleigh bashleigh added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Dec 22, 2020
@bashleigh bashleigh self-assigned this Dec 22, 2020
@bashleigh bashleigh mentioned this issue Jan 4, 2021
Merged
@codeninja
Copy link

Hush, it's fantastic and it solves my problem (at least in the 2.8 version of TypeORM). I would be happy to colab with you to bring the code up to the current 3.1 version which contains breaking changes.

@bashleigh
Copy link
Owner Author

Yes please! I also need to make it a lot more organised so that I can also fix an issue with parent/child saves (forget which)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bashleigh bashleigh

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codeninja @bashleigh