Modify and improve config change callback system #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -171,18 +171,26 @@ Configuration specific behaviour can be managed by registering a callback to | |||
| fire when a given configuration variable is set on the cli. The callback runs | |||
| *after* the corresponding environment variables are set. The callback function | |||
| is a 3-arity function that gets called with the original key (as a list of | |||
There was a problem hiding this comment.
Nice catch! Thanks!
|
Good work, I will wait for a rebase to squash some of these commits before going ahead with the merge. |
nickelization
force-pushed
the
nem-fix-config-hook-rpc
branch
5 times, most recently
from
beab01a
to
3fa2acc
Compare
We no longer pass the flags through to the config change callback, and the callback is executed directly on whichever node(s) are receiving the config change. Additionally, the return format of the config callbacks has changed so that we can display either a text status message for a standard "set", or a table of results when we use the --all flag.
And fix some dialyzer warnings too while we're at it.
nickelization
force-pushed
the
nem-fix-config-hook-rpc
branch
from
3fa2acc
to
ff4591c
Compare
Regardless of whether the callback displays any output, it's better to tell the user exactly what has been done and confirm that the variable has been modified.
Credit to Ian for pointing this out in review comments
nickelization
force-pushed
the
nem-fix-config-hook-rpc
branch
from
ff4591c
to
14e01b0
Compare
|
@ian-mi Alright, after much git wrangling, I think that's about as clean and tidy as I'm going to get it without having to start manually resolving merge conflicts. GitHub seems to have gotten a bit confused by all my rebases and force pushes, because it's showing the commits out of order now, so be careful to get the correct commit hash when you +1 it for Bors. (Currently 14e01b0). |
|
looks good, +1 14e01b0 |
|
I think Bors needs the +1 to be the first thing in the comment and on its own line. Let me try one more time... |
|
👍 14e01b0 |
borshop
added a commit
that referenced
this pull request
Aug 12, 2016
Modify and improve config change callback system Reviewed-by: nickelization
|
@borshop merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes break backwards compatibility with the old config callback API, but the new system is much easier to use in that it automatically deals with use of the --node and --all flags and calls the callbacks in the correct places. It also allows the callbacks to add output messages that can be displayed back to the user. In the case of the --all flag, all the results will now be displayed back to the user in a table.
This PR also updates the documentation appropriately, and adds extensive unit tests for the clique "set" command.