Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify and improve config change callback system #74

Merged
merged 6 commits into from
Aug 12, 2016
Merged

Modify and improve config change callback system #74

merged 6 commits into from
Aug 12, 2016

Commits on Aug 12, 2016

  1. Update README to reflect new cfg callback system

    @nickelization
    nickelization committed Aug 12, 2016
    Configuration menu
    Copy the full SHA
    6e58775 View commit details
    Browse the repository at this point in the history

  2. Modify "set" to use new config callback style 

    We no longer pass the flags through to the config change callback, and
the callback is executed directly on whichever node(s) are receiving the
config change. Additionally, the return format of the config callbacks
has changed so that we can display either a text status message for a
standard "set", or a table of results when we use the --all flag.
    @nickelization
    nickelization committed Aug 12, 2016
    Configuration menu
    Copy the full SHA
    4740e5d View commit details
    Browse the repository at this point in the history

  3. Improve error handling for badrpc errors 

    And fix some dialyzer warnings too while we're at it.
    @nickelization
    nickelization committed Aug 12, 2016
    Configuration menu
    Copy the full SHA
    eb5dec5 View commit details
    Browse the repository at this point in the history

  4. Improve output for "set" command 

    Regardless of whether the callback displays any output, it's
better to tell the user exactly what has been done and confirm
that the variable has been modified.
    @nickelization
    nickelization committed Aug 12, 2016
    Configuration menu
    Copy the full SHA
    dadc5e1 View commit details
    Browse the repository at this point in the history

  5. Simplify the run_callback function 

    Credit to Ian for pointing this out in review comments
    @nickelization
    nickelization committed Aug 12, 2016
    Configuration menu
    Copy the full SHA
    5970a9f View commit details
    Browse the repository at this point in the history

  6. Add full suite of unit tests for the "set" command

    @nickelization
    nickelization committed Aug 12, 2016
    5 Configuration menu
    Copy the full SHA
    14e01b0 View commit details
    Browse the repository at this point in the history