-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depend on system snappy (With OSX fix) #272
Conversation
@hmmr @ioolkos @martinsumner This one is passing now on both Linux and OSX, don't have a FreeBSD box myself but should be fine there too 🤞🏽 . See passing tests at https://github.com/codeadict/eleveldb/actions/runs/4239145446/jobs/7366922850 |
Confirming this works on Ubuntu. |
Looks like Github actions are stuck on the OTP 22 job:
Might be a good idea to cancel and re-run them. |
Indeed @ioolkos , confirmed it works on FreeBSD:
|
@hmmr, @martinsumner do you see a possibility to merge this? |
There's a fair bit of details specific to OSX way beyond my expertise, so I have to trust those details are done right. As long as it builds on linux (which it does), I'm giving my +1, but others should have a look. |
@hmmr thanks for your answer and your +1. Fair enough on the OSX remark. @codeadict can consult on this, maybe ensuring enough "separation" between OSX and Linux builds is enough. Or maybe that's already cleanly given here. |
Will do some testing of my own over the next couple of days just to double-check everything is all OK. I don't have the skills or knowledge to do a full review of the changes myself, but I think it might be fair to say there has been sufficient eyes on this, and sufficient testing to move forward. This PR does resolve the problem we had running Riak on OSX Catalina, which is helpful to me personally. @nsaadouni - do you have any objections to this being merged? |
I'm free for any help needed on this, have some macs to test with different versions but also the CI in this PR runs on OSX ensuring this works well in OSX with all the OTP versions supported. |
This builds on top of @hmmr 's #271.
rebar.config
, it was using the old config styleFixes #270