Multiple values for the same Riak index now supported #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
converting to/from a domain object. @RiakIndex annoted fields no longer encoded into JSON using the JSONConverter (this is now consistent with our other annotations fixes #135
|
I merged your changes from your branch into mine (parametrized type check on method and field like in yours), added tests for index at method and fixed possible NullPointerException (If the Field of type Set is null) |
rather than calling add(). More efficient due to locking.
ghost
assigned 
|
The tests added by this PR pass, but other tests fail against 1.2 (I assume this may be a 1.2-related issue, not related to this PR.) Test failures here: https://gist.github.com/3241149 |
added 2 commits
August 3, 2012 14:55
fields annotated with @RiakIndex are no longer automatically included by the JSON converter.
|
I was working on three different PRs all having to do with annotation processing. I forgot that this needed to be merged with master after one of those got merged. All worky now. |
broach
added a commit
that referenced
this pull request
Aug 3, 2012
Multiple values for the same Riak index now supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple values for the same Riak index now supported converting
to/from a domain object.
@RiakIndex annotated fields no longer encoded into JSON using
the JSONConverter (this is now consistent with our other
annotations
fixes #135