Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RiakObject (and all it's stuff) to be Serializable #698

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

srgg
Copy link
Contributor

@srgg srgg commented Jan 20, 2017

Description

The RiakObject as well as all it's attributes were marked as Serializable and serialVersionUIDs were added accordingly.

Related Issue

Motivation and Context

In Spark Connector project there is a need to use RiakObject as a default mapped type for the Riak KV RDD.

How Has This Been Tested?

Additional test case has been added in the scope of this PR.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Javadoc comments for any new public classes, interfaces, etc.
  • A basho_docs PR for new or changed features (basho/basho_docs#???)

Pull requests that are small and limited in scope are most welcome.

@@ -443,4 +445,16 @@ public final IndexType getType()

abstract T createIndex();
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this section?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants