Beams in basho-patches don't take precedence over existing code #126
Labels
Comments
|
I just ran into this. It needs fixing. |
|
I found out why this happens, RUNNER_LIB_DIR is wrong when we build a package (for local builds it is ./lib, which is correct). Proof: So you can see that -pa /usr/lib/riak/basho-patches is there but: And in the riak script: The path should be /usr/lib/riak/lib/basho-patches/ RUNNER_LIB_DIR is used nowhere else in the file, so it should be safe to fix. This happened with the ubuntu package, have not tested the others, but it also looks broken for the other platforms. |
ghost
assigned
jaredmorrow
added a commit
that referenced
this issue
Aug 11, 2012
…settings In devrel and source builds, `platform_lib_dir` gets set to the `lib` directory that is created by reltool. In all packages though, this directory is copied along with the `releases` and `erts-*` directories into the system lib directory. So in all packages `platform_lib_dir` gets defined as a top level directory containing `lib`, `releases`, and `erts-*`. The `riak` script attempts to set the load paths based on this `platform_lib_dir` setting so source builds act differently than package builds. This change fixes that inconsistency and defines a new variable `platform_base_dir` as the new system lib directory. `platform_lib_dir` is then defined as `platform_base_dir/lib` to match up with devrel/source builds. See: #126
|
Fixed. |
hmmr
pushed a commit
that referenced
this issue
Nov 8, 2016
…settings In devrel and source builds, `platform_lib_dir` gets set to the `lib` directory that is created by reltool. In all packages though, this directory is copied along with the `releases` and `erts-*` directories into the system lib directory. So in all packages `platform_lib_dir` gets defined as a top level directory containing `lib`, `releases`, and `erts-*`. The `riak` script attempts to set the load paths based on this `platform_lib_dir` setting so source builds act differently than package builds. This change fixes that inconsistency and defines a new variable `platform_base_dir` as the new system lib directory. `platform_lib_dir` is then defined as `platform_base_dir/lib` to match up with devrel/source builds. See: #126
hmmr
pushed a commit
that referenced
this issue
Nov 8, 2016
add a riak_snmp config block to app.config
martincox
pushed a commit
that referenced
this issue
Jan 31, 2022
Protobuffs messages for Time Series Reviewed-by: gordonguthrie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The code path "lib/basho-patches" was recently added to Riak's start up using the "-pa" flag:
riak/rel/files/riak
Line 232 in 083f666
riak/rel/files/riak-admin
Line 341 in 083f666
riak/rel/files/riak-admin
Line 361 in 083f666
riak/rel/files/riak-admin
Line 380 in 083f666
riak/rel/files/riak-admin
Line 398 in 083f666
Unfortunately, it does not appear that beams in this directory override existing beams. For example, Riak ships with a patched "etop_txt.beam" but on start up code:clash/0 indicates this version is hidden:
Also, code:which/1 does not show the patched version:
The text was updated successfully, but these errors were encountered: