Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Beams in basho-patches don't take precedence over existing code #126
The code path "lib/basho-patches" was recently added to Riak's start up using the "-pa" flag:
Unfortunately, it does not appear that beams in this directory override existing beams. For example, Riak ships with a patched "etop_txt.beam" but on start up code:clash/0 indicates this version is hidden:
Also, code:which/1 does not show the patched version:
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
I found out why this happens, RUNNER_LIB_DIR is wrong when we build a package (for local builds it is ./lib, which is correct).
So you can see that -pa /usr/lib/riak/basho-patches is there
And in the riak script:
The path should be /usr/lib/riak/lib/basho-patches/
RUNNER_LIB_DIR is used nowhere else in the file, so it should be safe to fix.
This happened with the ubuntu package, have not tested the others, but it also looks broken for the other platforms.