Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riak-debug - check /etc/default/riak (ulimit should be set there) #614

Closed

Conversation

binarytemple
Copy link

http://docs.basho.com/riak/1.4.10/ops/tuning/open-files-limit/#Linux

It is very common for Ubuntu users to forget to set ulimit -n 66xxx in /etc/default/riak

This adds an additional check for this file to riak-debug

@binarytemple
Copy link
Author

@jpease does this sound like a good idea? Originated in ticket 9129 - wasted two CSE days.

@pyrrho
Copy link
Contributor

pyrrho commented Feb 5, 2015

No reason not to do this.
Because /etc/default/riak is an Ubuntu-specific thing, I'd say changing the second line to

[ `uname -a | grep -i "ubuntu" -c` -gt 0 ] && [ ! -f /etc/default/riak ] && dump etc_default_riak echo "error: /etc/default/riak missing"

@kesslerm
Copy link

kesslerm commented Feb 9, 2015

Checking for distribution specific, undocumented strings is usually a bad idea. I'd just leave out the second line altogether. If the config file exists, collect it, otherwise not. Also, apart from Ubuntu, there are other distributions that make use of /etc/default, and the equivalent /etc/sysconfig exists on RedHat and SuSE.

@pyrrho
Copy link
Contributor

pyrrho commented Feb 11, 2015

I was under the impression that only Ubuntu or Ubuntu-based systems made use of /etc/default. As that seems to be an incorrect assumption, I agree that the second line should be left.

@martincox martincox closed this Jun 14, 2019
@martincox martincox deleted the feature/capture-etc-default-riak-in-riak-debug branch June 14, 2019 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants