Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard security sources overlapping with regular user sources causes issues #488

Merged
merged 1 commit into from
Jan 10, 2014

Conversation

Vagabond
Copy link
Contributor

@Vagabond Vagabond commented Jan 2, 2014

./rel/riak/bin/riak-admin security add-user andrew
./rel/riak/bin/riak-admin security add-source andrew 127.0.0.1/32 trust
./rel/riak/bin/riak-admin security add-source all 127.0.0.1/32 trust
./rel/riak/bin/riak-admin security print-sources
RPC to 'riak@127.0.0.1' failed: {'EXIT',
                                 {badarg,
                                  [{erlang,binary_to_list,[all],[]},
                                   {riak_core_security,
                                    '-prettyprint_users/2-lc$^0/1-0-',1,
                                    [{file,"src/riak_core_security.erl"},
                                     {line,70}]},
                                   {riak_core_security,
                                    '-prettyprint_users/2-lc$^0/1-0-',1,
                                    [{file,"src/riak_core_security.erl"},
                                     {line,70}]},
                                   {riak_core_security,prettyprint_users,2,
                                    [{file,"src/riak_core_security.erl"},
                                     {line,70}]},
                                   {riak_core_security,
                                    '-print_sources/1-lc$^0/1-0-',1,
                                    [{file,"src/riak_core_security.erl"},
                                     {line,85}]},
                                   {riak_core_security,print_sources,1,
                                    [{file,"src/riak_core_security.erl"},
                                     {line,85}]},
                                   {rpc,'-handle_call_call/6-fun-0-',5,
                                    [{file,"rpc.erl"},{line,205}]}]}}

Sources that overlap with an 'all' source need to be handled better, somehow.

See also #451

@ghost ghost assigned Vagabond Dec 23, 2013
@Vagabond
Copy link
Contributor Author

Vagabond commented Jan 2, 2014

Commit added to address this.

@buddhisthead
Copy link
Contributor

@Vagabond , can you summarize the problem and the solution here, please?

@andrewjstone
Copy link
Contributor

  • run manual test on develop to ensure breakage
  • run test with fix to ensure it works
  • code review

👍

Vagabond added a commit that referenced this pull request Jan 10, 2014
Wildcard security sources overlapping with regular user sources causes issues
@Vagabond Vagabond merged commit 73aff56 into develop Jan 10, 2014
@jrwest jrwest modified the milestones: 2.0-beta, 2.0 Mar 24, 2014
@seancribbs seancribbs deleted the adt-overlapping-sources branch April 1, 2015 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants