Skip to content

Wildcard security sources overlapping with regular user sources causes issues #488

Merged
merged 1 commit into from Jan 10, 2014

4 participants

@Vagabond
./rel/riak/bin/riak-admin security add-user andrew
./rel/riak/bin/riak-admin security add-source andrew 127.0.0.1/32 trust
./rel/riak/bin/riak-admin security add-source all 127.0.0.1/32 trust
./rel/riak/bin/riak-admin security print-sources
RPC to 'riak@127.0.0.1' failed: {'EXIT',
                                 {badarg,
                                  [{erlang,binary_to_list,[all],[]},
                                   {riak_core_security,
                                    '-prettyprint_users/2-lc$^0/1-0-',1,
                                    [{file,"src/riak_core_security.erl"},
                                     {line,70}]},
                                   {riak_core_security,
                                    '-prettyprint_users/2-lc$^0/1-0-',1,
                                    [{file,"src/riak_core_security.erl"},
                                     {line,70}]},
                                   {riak_core_security,prettyprint_users,2,
                                    [{file,"src/riak_core_security.erl"},
                                     {line,70}]},
                                   {riak_core_security,
                                    '-print_sources/1-lc$^0/1-0-',1,
                                    [{file,"src/riak_core_security.erl"},
                                     {line,85}]},
                                   {riak_core_security,print_sources,1,
                                    [{file,"src/riak_core_security.erl"},
                                     {line,85}]},
                                   {rpc,'-handle_call_call/6-fun-0-',5,
                                    [{file,"rpc.erl"},{line,205}]}]}}

Sources that overlap with an 'all' source need to be handled better, somehow.

See also #451

@Vagabond Vagabond was assigned Dec 23, 2013
@Vagabond
Vagabond commented Jan 2, 2014

Commit added to address this.

@buddhisthead

@Vagabond , can you summarize the problem and the solution here, please?

@andrewjstone
  • run manual test on develop to ensure breakage
  • run test with fix to ensure it works
  • code review

:+1:

@Vagabond Vagabond merged commit 73aff56 into develop Jan 10, 2014
@jrwest jrwest modified the milestone: 2.0-beta, 2.0 Mar 24, 2014
@seancribbs seancribbs deleted the adt-overlapping-sources branch Apr 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.