Fix Dialyzer warnings #528

seancribbs · 2014-02-11T15:46:02Z

Getting a clean slate. Only remaining warnings may be:

Unknown functions:
  cluster_info:format/3
  cluster_info:register_app/1

Those will disappear if cluster_info is on the code path.

jrwest · 2014-02-18T19:26:35Z

src/riak_core_claimant.erl

-        {legacy, _} ->
-            {ignore, legacy};
+        {error, invalid_resize_claim} ->
+            lager:error("invalid_resize_claim BUG");


this probably doesn't need to log. just surface the error to the user? or does this path not bubble back up that far...need to look...

ok we should be able to bubble this up to the user like so (sorry this is going to be a little verbose because im working through it as i type):

maybe_commit_staged/2 where this change has been made is called within a riak_core_ring_manager:ring_trans/2 so instead of logging we can return {ignore, invalid_resize_claim} on L402. the current implementation is actually an invalid return value for the ring_trans/2 call (although the ring manager handles this)

the {ignore, invalid_resize_claim} will be transformed to {error, invalid_resize_claim} here https://github.com/basho/riak_core/blob/bugfix/realtalk/dialyze/src/riak_core_claimant.erl#L389-L390 and this ultimately bubbles up to the caller as the return value of riak_core_claimant:commit/1

we will have to add a new case to https://github.com/basho/riak_core/blob/develop/src/riak_core_console.erl#L742-L761 to display the error to the user. something like https://github.com/basho/riak_core/blob/develop/src/riak_core_console.erl#L610-L614

How's this?

io:format("Unable to commit staged ring changes while ring is resizing.~n" "Check that there are no pending changes in 'riak-admin ring-status'~n" "If there are, try again once they are completed,~n" "Otherwise try again shortly.~n");

sorry for the delay:

"Unable to commit staged ring changes while ring is resizing" -> "Unable to commit staged ring changes"

The issue is not that the ring is resizing but that another operation took place (e.g. unstaged join) between the plan and the commit. Not sure how to best explain that, so figure its easier just to be short.

seancribbs · 2014-02-18T19:30:59Z

Revert lists:foreach into LCs which are faster, underscore match result.
Break out riak_core_vnode:vnode_forward.
Address Fix Dialyzer warnings #528 (comment)
Restore deleted annotations to riak_core_apl functions.

Some of these should really cause crashes when errors are returned, since later expressions expect them to have succeeded.

Removed the related dead code.

…don't have to match.

@jonmeredith

TODO: Ask @jonmeredith @jtuple what this was for

…ported. The case where it returns verbose information is only useful for the test, and should probably instead be tested with EQC.

@jrwest

TODO: This seems like a real bug that should be addressed. Ask @jrwest

Since we expect this to succeed (some other node just asked us to rejoin), logging an error when it doesn't seems most reasonable.

riak_core_handoff_manager.erl:392: The pattern {F, 'dynamic'} can never match the type 'undefined' | {non_neg_integer(),'bytes' | 'objects'}

riak_core_handoff_receiver.erl:25: Callback info about the riak_core_gen_server behaviour is not available

andrewjstone · 2014-02-22T19:11:15Z

Yep. We definitely discussed removing that since it's covered by r_t. No
idea why it fails in particular locally. After 2-3 weeks of not touching
it, I think I'm just going to remove it.

On Sat, Feb 22, 2014 at 2:03 PM, Sean Cribbs notifications@github.comwrote:

There seems to be a race or something in this testhttps://github.com/basho/riak_core/blob/bugfix/realtalk/dialyze/src/riak_core_vnode_proxy.erl#L357-L372.
From buildbot:

riak_core_vnode_proxy: overload_test_ (should not discard in normal operation)...failed
in function riak_core_vnode_proxy:'-overload_test_/0-fun-5-'/2 (src/riak_core_vnode_proxy.erl, line 368)
**error:{assertEqual_failed,[{module,riak_core_vnode_proxy},
{line,368},
{expression,"Count"},
{expected,50001},
{value,47842}]}

Reply to this email directly or view it on GitHubhttps://github.com//pull/528#issuecomment-35811112
.

jrwest · 2014-02-27T18:39:52Z

src/riak_core_dtrace.erl

@@ -127,12 +127,7 @@ put_tag(Tag) ->
        true ->
            FTag = iolist_to_binary(Tag),
            put(?DTRACE_TAG_KEY, FTag),
-            case get(?MAGIC) of
-                dtrace ->
-                    dtrace:put_utag(FTag);


this change seems to be removing some functionality? put_utag vs. put_tag?

dtrace module was from Scott's patch before it was fixed-up/merged into OTP. There is no such module anymore.

jrwest · 2014-02-27T19:15:14Z

src/riak_core_node_watcher.erl

@@ -325,8 +325,7 @@ handle_info({'DOWN', Mref, _, _Pid, _Info}, State) ->

            %% Update our list of active services and ETS table
            Services = ordsets:del_element(Id, State#state.services),
-            S3 = S2#state { services = Services },
-            local_update(S3),
+            S3 = local_update(S2#state { services = Services }),


I think there is a case here where we can lose the correct state because local_update/1 may return ok [1]

[1] https://github.com/basho/riak_core/blob/bugfix/realtalk/dialyze/src/riak_core_node_watcher.erl#L487-L490

Notice that broadcast is called after the case statement in that function.

ah, yes. my mistake

Was just looking at the top of the thread, and wanted to note that you can
add -compile(inline_list_funcs). to the top to get the LC optimizations
added to standard lists module calls.

@evanmcc Interesting. Should we be doing that globally?

Also, the other argument for LCs even when the return value is not used is clarity/visual noise reduction.

I don't know. It's something that I'd need to test. Maybe we can enable
it at the start of the next dev cycle so we have a long time to hopefully
run into any issues.

jrwest · 2014-02-28T01:06:28Z

src/riak_core_apl.erl

@@ -35,23 +35,24 @@
 -include_lib("eunit/include/eunit.hrl").
 -endif.

-type index() :: non_neg_integer().
+-type index() :: chash:index_as_int().
 -type n_val() :: non_neg_integer().
 -type ring() :: riak_core_ring:riak_core_ring().
 -type preflist() :: [{index(), node()}].
 -type preflist2() :: [{{index(), node()}, primary|fallback}].


we're probably nearing the point where we should try to stop making new changes, but couldn't help but comment that i really wish this were something like preflist_ann() or annotated_preflist() rather than preflist2().

That makes sense, will fix.

Sean Cribbs

On Feb 27, 2014, at 7:06 PM, Jordan West notifications@github.com wrote:

In src/riak_core_apl.erl:

@@ -35,23 +35,24 @@
-include_lib("eunit/include/eunit.hrl").
-endif.

--type index() :: non_neg_integer().
+-type index() :: chash:index_as_int().
-type n_val() :: non_neg_integer().
-type ring() :: riak_core_ring:riak_core_ring().
-type preflist() :: [{index(), node()}].
-type preflist2() :: [{{index(), node()}, primary|fallback}].
we're probably nearing the point where we should try to stop making new changes, but couldn't help but comment that i really wish this were something like preflist_ann() or annotated_preflist() rather than preflist2().

—
Reply to this email directly or view it on GitHub.

Addressed in 00086a7

jrwest · 2014-02-28T03:52:56Z

src/riak_core_ring.erl

-    true;
-legacy_ring(_) ->
-    false.
-
 %% @doc Upgrade old ring structures to the latest format.


it might be worth adding a comment to upgrade/1 and downgrade/1 as to why the functions do basically nothing. long term it would probably be nice to remove them (as any future upgrade/downgrade may work differently)

jrwest · 2014-02-28T04:24:05Z

seeing some issues running verify_dynamic_ring against this branch. lots of log messages like the one below. investigating...

20:20:07.354 [error] Error: riak_core_ring/ring_ready called on tainted ring

update 1:

same issue with verify_build_cluster, in this case, the log messages are in the riak logs only.

update 2:

I think i've isolated the issue to some of the recent legacy gossip removal changes. the errors do not appear when rolling back to a5c2443

seancribbs · 2014-02-28T21:33:38Z

Closing this in favor of a PR that excludes:

Changes to riak_core_security, since that changed several times during the course of this work.
Removal of anything related to legacy gossip, which should be separate.

seancribbs added 2 commits February 17, 2014 22:44

Fix unmatched returns in hashtree

a07904e

Remove specs from riak_core_apl that dialyzer can infer

1be189d

jrwest reviewed Feb 18, 2014
View reviewed changes

seancribbs added 26 commits February 18, 2014 14:30

Fix unknown types caused by typos

0fa9183

Match some expected return values that are important

032988e

Some of these should really cause crashes when errors are returned, since later expressions expect them to have succeeded.

RIP Legacy gossip

064a5b5

Removed the related dead code.

Background manager types were incorrectly specified

092ed75

Split resolve/2 into to two functions which have disjoint signatures.

acb7455

Fix some type warnings related to timers

8f8970b

Correct the type of human_time/3, was too narrow

f0f5531

Remove overly verbose annotations that can be inferrred

2de80a1

Remove case clauses in riak_core_security that will never match

a959718

orddict:orddict/0, not orddict:orddict/2

87d5862

Simplify the return type of maybe_ensure_vnodes_started/1 so callers …

7717aeb

…don't have to match.

Comment out this unused expression.

8f3a142

TODO: Ask @jonmeredith @jtuple what this was for

equal_cstate/3 is never called with true (except in tests) and not ex…

1941854

…ported. The case where it returns verbose information is only useful for the test, and should probably instead be tested with EQC.

Fix two obscure unmatched returns.

64e0348

Correct case for missing clause related to ring resizing.

a467c04

TODO: This seems like a real bug that should be addressed. Ask @jrwest

Remove commented code.

5fd11b8

Unify the type of case expression so we need not match it.

d220fa7

Remove more legacy gossip warnings

3d52d75

Match the return value of rpc_every_member.

d0753a6

The function() type refers to funs, not function names.

d695207

Value is returned along with unit.

0435a9c

Match the return value of riak_core:join when rejoining.

0921f89

Since we expect this to succeed (some other node just asked us to rejoin), logging an error when it doesn't seems most reasonable.

Match the return value of timer:apply_after.

8157681

Fix type for dynamic handoff size status.

97cbeb1

riak_core_handoff_manager.erl:392: The pattern {F, 'dynamic'} can never match the type 'undefined' | {non_neg_integer(),'bytes' | 'objects'}

Add callback info for gen_nb_server.

4f8ea20

Add callback info for riak_core_gen_server.

75a0756

riak_core_handoff_receiver.erl:25: Callback info about the riak_core_gen_server behaviour is not available

Change those 'ok' matches to _ for safety.

a5c2443

jrwest reviewed Feb 27, 2014
View reviewed changes

Remove legacy gossip module.

30bde57

jrwest reviewed Feb 27, 2014
View reviewed changes

seancribbs added 5 commits February 27, 2014 14:17

Remove more traces of legacy gossip.

4255964

Update ring test fixture since #chstate{} is gone.

d54aa8a

Use ets:tab() instead of tid() | atom().

e320072

Centralize definition of binary and integer chash offset values.

ceec2d9

Narrow a few types in riak_core_ring.

481d711

jrwest reviewed Feb 28, 2014
View reviewed changes

Rename preflist2 type to preflist_ann.

00086a7

jrwest reviewed Feb 28, 2014
View reviewed changes

seancribbs mentioned this pull request Feb 28, 2014

Fixes for YZ dialzyer warnings #539

Closed

seancribbs closed this Feb 28, 2014

This was referenced Feb 28, 2014

Fix dialyzer warnings #540

Merged

Remove legacy gossip #541

Closed

seancribbs added a commit that referenced this pull request Mar 1, 2014

Port dialyzer warning fixes from #528.

3d80525

seancribbs added a commit that referenced this pull request Mar 1, 2014

Port dialyzer warning fixes from #528.

daf06af

seancribbs deleted the bugfix/realtalk/dialyze branch March 1, 2014 23:18

jrwest mentioned this pull request Mar 24, 2014

Fix bad specification. #283

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Dialyzer warnings #528

Fix Dialyzer warnings #528

seancribbs commented Feb 11, 2014

jrwest Feb 18, 2014

jrwest Feb 18, 2014

seancribbs Feb 18, 2014

jrwest Feb 20, 2014

seancribbs commented Feb 18, 2014

andrewjstone commented Feb 22, 2014

jrwest Feb 27, 2014

seancribbs Feb 27, 2014

jrwest Feb 27, 2014

seancribbs Feb 27, 2014

jrwest Feb 27, 2014

evanmcc Feb 27, 2014

seancribbs Feb 27, 2014

seancribbs Feb 27, 2014

evanmcc Feb 27, 2014

jrwest Feb 28, 2014

seancribbs Feb 28, 2014

seancribbs Feb 28, 2014

jrwest Feb 28, 2014

jrwest commented Feb 28, 2014

seancribbs commented Feb 28, 2014

Fix Dialyzer warnings #528

Fix Dialyzer warnings #528

Conversation

seancribbs commented Feb 11, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seancribbs commented Feb 18, 2014

andrewjstone commented Feb 22, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jrwest commented Feb 28, 2014

seancribbs commented Feb 28, 2014